Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qt5 dependency for arch linux and debian/ubuntu #2841

Merged
merged 4 commits into from Jun 8, 2017
Merged

Add Qt5 dependency for arch linux and debian/ubuntu #2841

merged 4 commits into from Jun 8, 2017

Conversation

Areiser
Copy link
Contributor

@Areiser Areiser commented Jun 6, 2017

No description provided.

@flash-fire
Copy link
Contributor

It looks like I forgot to add the equivalent for apt get. Can you do that simultaneously to avoid two almost identical PRs?

@Areiser
Copy link
Contributor Author

Areiser commented Jun 6, 2017

Sure, I added the qt5-default package for ubuntu and also removed the old wxwidget package. Maybe an ubuntu user can confirm it works with qt5-default installed as I am not using Ubuntu?

Edit: I just checked and travis/appveyor are actually building with Qt 5.9 which is not provided by the ubuntu package. Maybe ubuntu users have to manually install a higher version of Qt (the package provides 5.7.1 for the newest ubuntu version).
Is there a minimum version of Qt required?

@AniLeo
Copy link
Member

AniLeo commented Jun 6, 2017

AppVeyor builds with 5.8, which was the version initially targeted for QT. I don't think AppVeyor supports 5.9 yet (appveyor/ci#1588). Travis builds with 5.9.

There's an unofficial PPA for QT 5.8 on Ubuntu at https://launchpad.net/~beineri/+archive/ubuntu/opt-qt58-trusty if needed

@hcorion
Copy link
Member

hcorion commented Jun 6, 2017

Yes, RPCS3 doesn't build with the old version of Qt Ubuntu trusty and xenial provide.
The unofficial qt 5.9 PPA is:
Trusty: https://launchpad.net/%7Ebeineri/+archive/ubuntu/opt-qt59-trusty
Xenial: https://launchpad.net/~beineri/+archive/ubuntu/opt-qt59-xenial
I'm not sure what the minimum is, but let's just say it's 5.8

@hcorion
Copy link
Member

hcorion commented Jun 6, 2017

Oh, just realized Zesty is the latest version, which has Qt 5.7, it should work with Zesty then.

@Areiser
Copy link
Contributor Author

Areiser commented Jun 7, 2017

I was just able to build rpcs3 on ubuntu 17.04 with clang 4.0 and a small modification.

I always hit this error though:
./bin/rpcs3
Fatal error:
Unhandled exception of type 'St13runtime_error': Can't create log file RPCS3.log (error Not found)
HOW TO REPORT ERRORS: Check the FAQ, README, other sources.
Please, don't send incorrect reports. Thanks for understanding.
Aborted (core dumped)

Any ideas?

Side note, running rpcs3 with sudo manages to crash sudo 😄
sudocrash

@hcorion
Copy link
Member

hcorion commented Jun 7, 2017

Sounds like you have the same issue as #2821 , it seems to be a 17.04 issue.

@Areiser
Copy link
Contributor Author

Areiser commented Jun 7, 2017

Building with gcc didn't work. Crazy memory leak and internal compiler error... Not sure what the problem is :/ Maybe my setup is broken but it is bare bones ubuntu...
screenshot from 2017-06-07 18-06-25

At this point I'd rather wait until somebody who built rpcs3 on ubuntu before confirms/denies that this works.

@hcorion
Copy link
Member

hcorion commented Jun 7, 2017

Maybe 17.04 is completely screwed?

@Areiser
Copy link
Contributor Author

Areiser commented Jun 7, 2017

I'm not sure. gcc 5 also fails to compile it, same spot as 6.3 (on vm.cpp):
[ 45%] Building CXX object rpcs3/CMakeFiles/rpcs3.dir/Emu/Memory/vm.cpp.o
cc1plus: warning: /home/mainuser/Documents/Programmieren/rpcs3/rpcs3/cotire/rpcs3_CXX_prefix.hxx.gch: created by a different GCC executable
virtual memory exhausted: Cannot allocate memory
rpcs3/CMakeFiles/rpcs3.dir/build.make:4451: recipe for target 'rpcs3/CMakeFiles/rpcs3.dir/Emu/Memory/vm.cpp.o' failed

This is a bit confusing because surely people compiled rpcs3 on Ubuntu 17.04 before. I don't want this PR to turn into a debug session/issue though, so is Qt 5.7 package fine or should I remove it @AniLeo ?
If 5.8+ is needed, I could point to the PPA in the readme.

@hcorion
Copy link
Member

hcorion commented Jun 7, 2017

I don't think we have any Ubuntu 17.04 users, other then the one in the issue I linked to earlier.
Currrently your running out of memory, are you running this in a VM? If so, try allocating more RAM.

@Areiser
Copy link
Contributor Author

Areiser commented Jun 8, 2017

I finally managed to build it on my 8gb desktop. The compiler suddenly allocates a lot of memory when compiling vm.cpp so that ~5gb of ram is used on my machine (usually hovers at about 1gb when compiling rpcs3) and my laptop only has 4gb which is why it failed.

With one small include adjustment for QUrl which seems to be needed on Qt 5.7, it works on ubuntu 17.04 with Qt 5.7 from the official repositories!
Rpcs3 on Ubuntu 17.04

@AniLeo
Copy link
Member

AniLeo commented Jun 8, 2017

You have to rebase with master and fix conflicts on travis script for it to build

@AniLeo AniLeo changed the title Add qt5-base dependency for arch linux Add Qt5 dependency for arch linux and debian/ubuntu Jun 8, 2017
@AniLeo AniLeo merged commit e5e95a3 into RPCS3:master Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants