rsx: Bug fixes #2861

kd-11 · 2017-06-11T10:20:50Z

Fix stencil clear values - Regression: FEAR 2 Demo #2810
Fix some buffer misalignment crashes when using debuggers or faulty drivers
Fix an old regression with God of War I and II from the collection - God of War 1&2 HD old regression #2626
Fix openGL clip space conversion (Z symmetry)
Add a workaround to fix shadow map generation
Add hardware PCF shadow support
Fix stencil buffer reset (Still a workaround atm)
Remove several hundred compilation warnings from rsx code
Improve SPIRV compilation speed by avoiding unnecessary SH context (re)creattion
Add a needed rsx method for wipeout HD
Fix index buffer generation when using a non-zero base offset
Drop vs user files from the repo
Added a toggle to ensure strict rendering mode. Currently only affects framebuffer feedback loops. When disabled, we ignore the feedback loop in vulkan and issue a texture barrier in ogl. When enabled, a duplicate texture is created to ensure this is not an issue but there is a tangible performance penalty. Defaults to OFF
Re-organized the graphics options tab a bit to separate main options from debugging options.

Current bugs

Crash compiling textureProj due to PCF samplers support
Crash when debug overlay is enabled (vulkan only)

mention-bot · 2017-06-11T10:20:51Z

@kd-11, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vlj, @Nekotekina and @jarveson to be potential reviewers.

MarioSonic2987 · 2017-06-11T10:52:26Z

@kd-11
This PR:

Master:

Xcedf · 2017-06-11T15:41:03Z

Confirm GoW issue is fixed, also fixed same depth issue in Ni No Kuni Demo
thx for the awesome work

kd-11 · 2017-06-12T13:31:07Z

Marking as WIP since touching this has uncovered alot of other issues.

woj1993 · 2017-06-13T15:11:19Z

@kd-11 What issues?
PS. Are you sure this is best option? I worry you fix might stay marked as WIP too long and will need another rewrite if it isn't merged now.

AniLeo · 2017-06-13T15:20:23Z

@woj1993 no need to worry, it will get merged relatively soon. We're running internal tests.

takhlaq · 2017-06-20T21:57:19Z

The Legend of Heroes: Trails of Cold Steel [BLUS31572]
looks good

Xcedf · 2017-06-20T22:00:28Z

Magnificent changes, now have perfect shadows in Tekken6 and Soul Calibur IV
but i also have a slowdown in some games if compare to master
here's the example,
master

this pr

will try to find more specific commit later

kd-11 · 2017-06-20T22:10:04Z

Disable the invalidate cache option. Should fix performance. Report if it does not.

Xcedf · 2017-06-20T22:19:26Z

Unfortunately not, doesn't affect performance at all tried both on and off
another example of fps drop Heavy Rain Demo menu
master 18fps
this pr 14fps

kd-11 · 2017-06-20T22:20:49Z

Odd. I'll look into it.

VadimSaveljev · 2017-06-20T22:27:31Z

Demon's souls reborn with this PR

Xcedf · 2017-06-20T22:32:48Z

Another issue
several games are fail to compile shaders
Army of Two
Lolipop Chainsaw
OGL:
F {rsx::thread} : class gl::glsl::link_exception thrown: linkage failed: 'Fragment info

0(115) : error C1031: swizzle mask element not present in operand "xyz"
0(128) : error C1031: swizzle mask element not present in operand "xyz"
0(130) : error C1031: swizzle mask element not present in operand "xyz"
0(133) : error C1031: swizzle mask element not present in operand "xyz"
(0) : error C2003: incompatible options for link
Vulkan:
E {rsx::thread} RSX: ERROR: 0:125: 'xyz' : vector swizzle selection out of range
ERROR: 0:125: 'assign' : cannot convert from ' global highp float' to ' temp highp 3-component vector of float'
ERROR: 0:125: '' : compilation terminated
ERROR: 3 compilation errors. No code generated.
E {rsx::thread} RSX:
F {rsx::thread} : class std::runtime_error thrown: Failed to compile fragment shader
(in file C:\rpcs3\rpcs3\Emu\RSX\VK\VKFragmentProgram.cpp:492)

kd-11 · 2017-06-20T22:33:49Z

Thats new with this build? If so, attach fragmentprogram.spirv here

Xcedf · 2017-06-20T22:49:08Z

Yes it's on this build, master is fine, here's the new files
https://mega.nz/#!rcZWmYrL!d01JENkZUAx514DmAB7hi7Xa1qL6HOBMZxpqngjJ9MQ

Sora3100 · 2017-06-20T23:00:14Z

OpenGL (the blue and normal textures seen below flicker along with the eyes):

Vulkan:

Also, the command menu in the bottom left seems to have a weird display bug
I can also confirm that Xillia 1/2 now displays shadows

MarioSonic2987 · 2017-06-21T04:13:40Z

Many games are improved with this PR:

Xcedf · 2017-06-21T08:28:10Z

Some info about my issues:
performance regression caused by cd3d7ef or previous 86465e9(but it has compilation issues, so can't tell for sure now)

kd-11 · 2017-06-21T08:35:08Z

Thanks alot. Its probably the former since it copies a texture in GPU memory and spams the log. Not sure it should be disabled though as using a current render target as input is a spec violation. I need to check for a way around that.

Xcedf · 2017-06-21T16:05:29Z

You're welcome
As for shader compilation issue: commit b31d937 is the cause
edited my pervious commit, gave wrong revision sorry
and slowdowns issue it's cd3d7ef for sure
tested only for vulkan, file VKTextureCache.h commenting out lines 492-497 fixes slowdowns, other code cause no slowdowns

kd-11 · 2017-06-22T06:23:46Z

Disabling those lines allows for a pretty serious spec violation that causes heavy flickering and broken graphics in some cases. It needs some more work to prevent the slowdown.

Grima04 · 2017-06-22T12:20:05Z

Grand Theft Auto V BLES01807

F 0:04:29.285507 {rsx::thread} class gl::glsl::link_exception thrown: linkage failed: 'Vertex info
0(77) : error C0000: syntax error, unexpected '.', expecting ')' at token "."
(0) : error C2003: incompatible options for link

LOG:
RPCS3_GTAV_22-06-2017.zip

Video:
https://www.youtube.com/watch?v=YUn41FgN6eE

…sues - Also set some default values for samplers in a cleaner way using their 'natural' float values

Need to find the proper command issued to discard all surfaces

- Create temporary copies for use with the draw call instead

Another fix for signed normalized formats; single component vectors are swizzled

- Fixes stencil volume shadows in a few games. This is part of the surface invalidation workarounds

…RV. Speedup

- Vertex buffer contents treat the base vertex as vertex 0 so we do the same for indices rsx: Fix vertex base indexing rsx: Properly fix non-zero offset indexed rendering

- Wrap unused parameters as comments to prevent C1400 - Fix sized variable conversions with explicit casts

rsx: Give more info when ring buffer allocations fail

…a bit code cleanup

uvraj · 2017-07-19T10:44:13Z

having loadscreen issues

uvraj · 2017-07-19T10:45:29Z

PR looks good so far

uvraj · 2017-07-19T10:57:44Z

F {rsx::thread} class std::runtime_error thrown: Unknown texture dimension 0
(in file C:\rpcs3\rpcs3\Emu\RSX\gcm_enums.cpp:137) getting this error

uvraj · 2017-07-19T17:49:40Z

games like minecraft are running pretty well :)

kd-11 · 2017-07-19T17:55:58Z

This was merged and closed 2 weeks ago. Latest rsx PR is #3026

kd-11 mentioned this pull request Jun 11, 2017

Regression: FEAR 2 Demo #2810

Closed

kd-11 force-pushed the vulkan branch from c5c564e to ac878b5 Compare June 11, 2017 14:33

Xcedf mentioned this pull request Jun 11, 2017

God of War 1&2 HD old regression #2626

Closed

kd-11 changed the title ~~rsx: Bug fixes~~ [WIP] rsx: Bug fixes Jun 12, 2017

kd-11 force-pushed the vulkan branch from ac878b5 to afb4765 Compare June 20, 2017 20:49

SakataGintokiYT mentioned this pull request Jun 20, 2017

GL: Dragon Ball Z: Burst Limit #2208

Closed

This was referenced Jun 21, 2017

GL/Vulkan : Resogun broken in-game graphic #1989

Closed

DX12: Naruto Shippuden: Ultimate Ninja Storm Generations- Shadow and depth issue #1949

Closed

kd-11 added 21 commits June 22, 2017 23:13

gl: Fix clip-space -> depth conversion. Fixes remaining depth read is…

6e8cda5

…sues - Also set some default values for samplers in a cleaner way using their 'natural' float values

vk/gl: Fix sampling of shadow2D textures

601dae3

rsx: Discard surface store contents once per frame (temp workaround)

f1f462d

Need to find the proper command issued to discard all surfaces

vk/gl: Do not sample currently bound render targets

820d578

- Create temporary copies for use with the draw call instead

rsx/gl/vk: Fix some warnings and whitespace issues (LF vs CRLF)

080604b

rsx: Fix clip space computations

38417f2

gl: Properly emulate signed normalized wide integers

f2c541c

Another fix for signed normalized formats; single component vectors are swizzled

rsx/gl/vk: Invert default stencil values

91f4fdf

- Fixes stencil volume shadows in a few games. This is part of the surface invalidation workarounds

gl: Silence log spam

cd84a3e

vk: Prefer optimal formats when clearing buffers

e35c187

vk: Avoid constantly reinitializing the SH context when compiling SPI…

18be0b1

…RV. Speedup

vk: Proper shutdown to avoid destroying resources still in use

40871db

rsx: Register NV4097_SET_COLOR_KEY_COLOR method.

f8e52bf

rsx: Handle non-zero base vertex better

46585ee

- Vertex buffer contents treat the base vertex as vertex 0 so we do the same for indices rsx: Fix vertex base indexing rsx: Properly fix non-zero offset indexed rendering

rsx: Code cleanup. Fixes several dozen warnings

23bb3f2

- Wrap unused parameters as comments to prevent C1400 - Fix sized variable conversions with explicit casts

rsx/ui: Make a few settings configurable via the GUI

62c4f37

rsx: Bug fixes

e8a6e66

rsx: Give more info when ring buffer allocations fail

rsx: Do not sample as pcf shader if writing a vector result

d95d47b

vk: Move resource init/destroy to constructor and destructor

5261801

vs: drop user files from shipped vs files

9296e63

rsx/gui: Add a strict mode toggle. Also reorganizes the graphics tab …

39b5dc7

…a bit code cleanup

kd-11 force-pushed the vulkan branch from 6a9e8fa to 39b5dc7 Compare June 22, 2017 20:14

kd-11 merged commit 72edf26 into RPCS3:master Jun 22, 2017

Megamouse mentioned this pull request Jul 3, 2017

Catherine missing letters from font (regression) #2945

Closed

kd-11 deleted the vulkan branch October 13, 2017 12:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rsx: Bug fixes #2861

rsx: Bug fixes #2861

kd-11 commented Jun 11, 2017 •

edited

Loading

mention-bot commented Jun 11, 2017

MarioSonic2987 commented Jun 11, 2017 •

edited

Loading

Xcedf commented Jun 11, 2017 •

edited

Loading

kd-11 commented Jun 12, 2017 •

edited

Loading

woj1993 commented Jun 13, 2017

AniLeo commented Jun 13, 2017

takhlaq commented Jun 20, 2017

Xcedf commented Jun 20, 2017 •

edited

Loading

kd-11 commented Jun 20, 2017

Xcedf commented Jun 20, 2017

kd-11 commented Jun 20, 2017

VadimSaveljev commented Jun 20, 2017

Xcedf commented Jun 20, 2017

kd-11 commented Jun 20, 2017

Xcedf commented Jun 20, 2017

Sora3100 commented Jun 20, 2017 •

edited

Loading

MarioSonic2987 commented Jun 21, 2017

Xcedf commented Jun 21, 2017

kd-11 commented Jun 21, 2017

Xcedf commented Jun 21, 2017 •

edited

Loading

kd-11 commented Jun 22, 2017

Grima04 commented Jun 22, 2017

uvraj commented Jul 19, 2017

uvraj commented Jul 19, 2017

uvraj commented Jul 19, 2017

uvraj commented Jul 19, 2017

kd-11 commented Jul 19, 2017

rsx: Bug fixes #2861

rsx: Bug fixes #2861

Conversation

kd-11 commented Jun 11, 2017 • edited Loading

mention-bot commented Jun 11, 2017

MarioSonic2987 commented Jun 11, 2017 • edited Loading

Xcedf commented Jun 11, 2017 • edited Loading

kd-11 commented Jun 12, 2017 • edited Loading

woj1993 commented Jun 13, 2017

AniLeo commented Jun 13, 2017

takhlaq commented Jun 20, 2017

Xcedf commented Jun 20, 2017 • edited Loading

kd-11 commented Jun 20, 2017

Xcedf commented Jun 20, 2017

kd-11 commented Jun 20, 2017

VadimSaveljev commented Jun 20, 2017

Xcedf commented Jun 20, 2017

kd-11 commented Jun 20, 2017

Xcedf commented Jun 20, 2017

Sora3100 commented Jun 20, 2017 • edited Loading

MarioSonic2987 commented Jun 21, 2017

Xcedf commented Jun 21, 2017

kd-11 commented Jun 21, 2017

Xcedf commented Jun 21, 2017 • edited Loading

kd-11 commented Jun 22, 2017

Grima04 commented Jun 22, 2017

uvraj commented Jul 19, 2017

uvraj commented Jul 19, 2017

uvraj commented Jul 19, 2017

uvraj commented Jul 19, 2017

kd-11 commented Jul 19, 2017

kd-11 commented Jun 11, 2017 •

edited

Loading

MarioSonic2987 commented Jun 11, 2017 •

edited

Loading

Xcedf commented Jun 11, 2017 •

edited

Loading

kd-11 commented Jun 12, 2017 •

edited

Loading

Xcedf commented Jun 20, 2017 •

edited

Loading

Sora3100 commented Jun 20, 2017 •

edited

Loading

Xcedf commented Jun 21, 2017 •

edited

Loading