-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pad Refactoring #3283
Pad Refactoring #3283
Conversation
@RipleyTom, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jarveson, @mputters and @georgemoralis to be potential reviewers. |
rpcs3/xinput_pad_handler.cpp
Outdated
pad->m_vibrateMotors.emplace_back(true, 0); | ||
pad->m_vibrateMotors.emplace_back(false, 0); | ||
|
||
bindings.push_back(std::make_pair(device_number, pad)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not emplace here too?
dialog_layout->addLayout(all_players); | ||
|
||
QHBoxLayout *buttons_layout = new QHBoxLayout(); | ||
QPushButton *ok_button = new QPushButton("OK"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tr("OK")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, isn't it better done via http://doc.qt.io/qt-5.9/qdialogbuttonbox.html#details ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not really needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Megamouse why? isn't the code here is just doing poor man's qdialogbuttonbox? With it, the dialog would have the standard buttons with the standard (to the user OS) button layout and translations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well i don't care. I'm fine with it either way.
QHBoxLayout *buttons_layout = new QHBoxLayout(); | ||
QPushButton *ok_button = new QPushButton("OK"); | ||
buttons_layout->addWidget(ok_button); | ||
QPushButton *cancel_button = new QPushButton("Cancel"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tr("Cancel")
7f8346c
to
0c9dd10
Compare
Yeah there is a bug(set the connects too early), fixing it |
It's better, but there's another pb: the /dev/input/event-numbers don't survive a reboot. |
So, I suggest to modify the current behaviour: |
b05b73e
to
54fe399
Compare
Evdev issue should be fixed(hcorion). |
The joystick is not recognized. I send you 2 logfiles: 1 with your PR, the 2nd on master (which is working) |
@toccata10 Make sure to delete |
I deleted my config_input.yml and tested. My tests were fine: unplug 1 stick, reboot,... everything worked as expected. Nice ! |
a05f6a6
to
91cbe8d
Compare
b5cceed
to
609a18a
Compare
Adds a window to setup multiple input types as once All controllers are now handled by a single thread [hcorion] evdev refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've poured over every inch of this PR and can confirm it is completely bug-free and ready for merge.
Adds a window to setup multiple input types as once
All controllers are now handled by a single thread
[hcorion] evdev refactor