Pad Refactoring by RipleyTom · Pull Request #3283 · RPCS3/rpcs3

RipleyTom · 2017-08-20T15:11:54Z

Adds a window to setup multiple input types as once
All controllers are now handled by a single thread
[hcorion] evdev refactor

mention-bot · 2017-08-20T15:11:56Z

@RipleyTom, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jarveson, @mputters and @georgemoralis to be potential reviewers.

danilaml · 2017-08-20T17:50:11Z

+	pad->m_vibrateMotors.emplace_back(true, 0);
+	pad->m_vibrateMotors.emplace_back(false, 0);
+
+	bindings.push_back(std::make_pair(device_number, pad));


why not emplace here too?

Megamouse · 2017-08-20T18:49:04Z

+	dialog_layout->addLayout(all_players);
+
+	QHBoxLayout *buttons_layout = new QHBoxLayout();
+	QPushButton *ok_button = new QPushButton("OK");


Btw, isn't it better done via http://doc.qt.io/qt-5.9/qdialogbuttonbox.html#details ?

it's not really needed

@Megamouse why? isn't the code here is just doing poor man's qdialogbuttonbox? With it, the dialog would have the standard buttons with the standard (to the user OS) button layout and translations.

Well i don't care. I'm fine with it either way.

Megamouse · 2017-08-20T18:49:22Z

+	QHBoxLayout *buttons_layout = new QHBoxLayout();
+	QPushButton *ok_button = new QPushButton("OK");
+	buttons_layout->addWidget(ok_button);
+	QPushButton *cancel_button = new QPushButton("Cancel");


tr("Cancel")

toccata10 · 2017-08-24T08:30:23Z

Nice improvement. A few tests with evdev (linux):

I launch rpcs3, and configure my pads like this for 2 players:

I click ok: it works.
I open again the gamepad config:

It attributes the same device to player 1 and 2

Suggestions:

When there are several devices, give the lowest to the 1st player, then another one for player 2, ...
If player 1 and player 2 are configured with evdev, but only 1 device is found, disable input for player 2: it doesn't make sense to me to have the same joystick controlling 2 different players. With Castle crashers for example, if I want to play alone, I plug 1 controller. If I want to play with a friend, I plug 2 controllers. It should work without having to re-open the pad config. With the present code, if I plug only 1 joystick, it'll create and control 2 players. Some games (street fighter HD remix) don't allow the same controller to play 2 fighters, but it's not universal.

RipleyTom · 2017-08-24T08:49:20Z

Yeah there is a bug(set the connects too early), fixing it
Current behavior is:
-On Pad Window: It will keep the input selected but revert to default device if it can't find the device
-On Game: if it can't find the device it reverts to null handler

toccata10 · 2017-08-24T14:00:11Z

It's better, but there's another pb: the /dev/input/event-numbers don't survive a reboot.
So, I have this on the log after a reboot, as my new number is 19.
E Joystick /dev/input/event14 is not present or accessible [previous status: 0]
E Joystick /dev/input/event13 is not present or accessible [previous status: 0]
although the pad configuration shows a device at number 19.
This results in a non-working stick (test with castle crashers).

toccata10 · 2017-08-24T15:42:20Z

So, I suggest to modify the current behaviour:
-On Pad Window: It will keep the input selected but revert to default device if it can't find the device. It tries to assign a different device to each player.
-On Game: if it can't find the device or the device is already used by another player, it reverts to null handler

RipleyTom · 2017-08-26T23:22:46Z

Evdev issue should be fixed(hcorion).
Also fixed a small issue with keyboard pad handler that crashed on SetRumble.

toccata10 · 2017-08-27T05:34:00Z

The joystick is not recognized. I send you 2 logfiles: 1 with your PR, the 2nd on master (which is working)
RPCS3-PadPb.zip
RPCS3-PadMaster.zip

hcorion · 2017-08-27T16:08:10Z

@toccata10 Make sure to delete ~/.config/rpcs3/config_input.yml before re-testing PadMagic, and then re-configuring your pads.

toccata10 · 2017-08-30T15:51:57Z

I deleted my config_input.yml and tested. My tests were fine: unplug 1 stick, reboot,... everything worked as expected. Nice !

Adds a window to setup multiple input types as once All controllers are now handled by a single thread [hcorion] evdev refactor

hcorion

I've poured over every inch of this PR and can confirm it is completely bug-free and ready for merge.

RipleyTom force-pushed the PadMagic branch from 20773a3 to 2a8b247 Compare August 20, 2017 17:33

danilaml reviewed Aug 20, 2017

View reviewed changes

Megamouse reviewed Aug 20, 2017

View reviewed changes

RipleyTom force-pushed the PadMagic branch 3 times, most recently from 7f8346c to 0c9dd10 Compare August 23, 2017 00:27

hcorion mentioned this pull request Aug 23, 2017

Fix evdev axis reversal #3303

Merged

RipleyTom force-pushed the PadMagic branch from bc13534 to 0dc8ad2 Compare August 24, 2017 13:31

RipleyTom force-pushed the PadMagic branch 5 times, most recently from b05b73e to 54fe399 Compare August 26, 2017 22:57

RipleyTom force-pushed the PadMagic branch from 54fe399 to 2205fc3 Compare August 27, 2017 18:10

RipleyTom mentioned this pull request Aug 28, 2017

XInput doesn't work if active controller is not controller 1 #3340

Closed

AniLeo requested a review from a user September 1, 2017 17:55

RipleyTom force-pushed the PadMagic branch 5 times, most recently from a05f6a6 to 91cbe8d Compare September 1, 2017 23:11

RipleyTom force-pushed the PadMagic branch 2 times, most recently from b5cceed to 609a18a Compare September 1, 2017 23:49

AniLeo added Enhancement Input labels Sep 2, 2017

RipleyTom force-pushed the PadMagic branch from 609a18a to 07ee108 Compare September 8, 2017 20:00

Pad Refactoring

af195a3

Adds a window to setup multiple input types as once All controllers are now handled by a single thread [hcorion] evdev refactor

RipleyTom force-pushed the PadMagic branch from 07ee108 to af195a3 Compare September 8, 2017 20:33

Merge branch 'master' into PadMagic

734976d

hcorion approved these changes Sep 8, 2017

View reviewed changes

AniLeo merged commit 0457f23 into RPCS3:master Sep 8, 2017

scribam mentioned this pull request Sep 12, 2017

Feature: Multiplayer input support (NOT Netplay) #2215

Closed

RipleyTom deleted the PadMagic branch June 4, 2019 17:18

Uh oh!

Uh oh!

Conversation

RipleyTom commented Aug 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mention-bot commented Aug 20, 2017

Uh oh!

danilaml Aug 20, 2017

Choose a reason for hiding this comment

Uh oh!

Megamouse Aug 20, 2017

Choose a reason for hiding this comment

Uh oh!

danilaml Aug 20, 2017

Choose a reason for hiding this comment

Uh oh!

Megamouse Aug 20, 2017

Choose a reason for hiding this comment

Uh oh!

danilaml Aug 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Megamouse Aug 20, 2017

Choose a reason for hiding this comment

Uh oh!

Megamouse Aug 20, 2017

Choose a reason for hiding this comment

Uh oh!

toccata10 commented Aug 24, 2017

Uh oh!

RipleyTom commented Aug 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

toccata10 commented Aug 24, 2017

Uh oh!

toccata10 commented Aug 24, 2017

Uh oh!

RipleyTom commented Aug 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

toccata10 commented Aug 27, 2017

Uh oh!

hcorion commented Aug 27, 2017

Uh oh!

toccata10 commented Aug 30, 2017

Uh oh!

hcorion left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

RipleyTom commented Aug 20, 2017 •

edited

Loading

danilaml Aug 20, 2017 •

edited

Loading

RipleyTom commented Aug 24, 2017 •

edited

Loading

RipleyTom commented Aug 26, 2017 •

edited

Loading

hcorion left a comment •

edited

Loading