Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sceNpManager callback regression #3553

Merged
merged 3 commits into from
Oct 12, 2017
Merged

Conversation

Farseer2
Copy link
Contributor

@Farseer2 Farseer2 commented Oct 8, 2017

Just reverse one of #2894 changes. As seen in Midnight Club: LA, the callback isn't initially called to notify the network status.
Should fix the regression of GTA 4, 5 and MC:LA

Thanks to Kravicka for notifying for spotting the regression and tracking it down

@kamer1337
Copy link

fixed regression in Tony Hawk's Pro Skater HD

@Kravickas
Copy link
Contributor

We cant fully state that fix worked because there is another regression in GTA 4, 5 and MC:LA and skate 3
#3448

@Zangetsu38
Copy link
Contributor

Zangetsu38 commented Oct 10, 2017

I hope you can fix problem in Gal*Gun game with this function "sceNpManagerRegisterCallback"
game works if i set "else" condition, but break other game, need correctly implement "else if" condition, but i don't know why game call, enter in log

·W 0:00:24.256572 {PPU[0x1000000] Thread (main_thread) [0x00ac1898]} sceNp: sceNpManagerRegisterCallback(callback=*0x35a3c0, arg=*0x23920000)
·F 0:00:24.256760 {PPU[0x1000000] Thread (main_thread) [0x00229658]} MEM: Access violation writing location 0x0

@hcorion
Copy link
Member

hcorion commented Oct 12, 2017

Please rebase with current master, Neko's fs fixes have been merged, so the GTA 4/5 + Skate III regression should be fixed.

@Nekotekina Nekotekina merged commit e8bde58 into RPCS3:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants