Silence some warnings #3692
Closed
Silence some warnings #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcorion
force-pushed
the
silence-warnings
branch
from
414ff65
to
7b220da
Compare
Nekotekina
reviewed
Nov 3, 2017
Utilities/Log.cpp
Outdated
| } | ||
|
|
There was a problem hiding this comment.
It shouldn't be abandoned in most cases
Nekotekina
reviewed
Nov 3, 2017
rpcs3/Emu/Cell/lv2/lv2.cpp
Outdated
| @@ -969,9 +969,8 @@ void fmt_class_string<CellError>::format(std::string& out, u64 arg) | |||
| STR_CASE(CELL_ESDKVER); | |||
| STR_CASE(CELL_ENOLICDISC); | |||
| STR_CASE(CELL_ENOLICENT); | |||
| default: return unknown; | |||
There was a problem hiding this comment.
That was the point: see the warning and add unimplemented case.
There was a problem hiding this comment.
Ok, reverted in hopes that it gets implement soon 👍
hcorion
force-pushed
the
silence-warnings
branch
from
7b220da
to
78ee868
Compare
OverlordCW
reviewed
Nov 3, 2017
rpcs3/Emu/RSX/GL/GLHelpers.cpp
Outdated
| @@ -22,8 +22,8 @@ namespace gl | |||
| case rsx::primitive_type::quads: return GL_TRIANGLES; | |||
| case rsx::primitive_type::quad_strip: return GL_TRIANGLE_STRIP; | |||
| case rsx::primitive_type::polygon: return GL_TRIANGLES; | |||
| default: fmt::throw_exception("unknow primitive type" HERE); | |||
There was a problem hiding this comment.
Put all throws on their own line. breakpoints are the only way to obtain backtraces to identify the culprit
There was a problem hiding this comment.
Good catch, thanks @OverlordCW .
Should be addressed @kd-11 .
hcorion
force-pushed
the
silence-warnings
branch
from
78ee868
to
1307ca2
Compare
kd-11
requested changes
Nov 20, 2017
| @@ -202,6 +202,7 @@ void cfg::encode(YAML::Emitter& out, const cfg::_base& rhs) | |||
| out << YAML::EndMap; | |||
| return; | |||
| } | |||
| default: LOG_ERROR(GENERAL, "Attempting to cfg encode an unimplemented type."); | |||
| @@ -1379,9 +1379,8 @@ namespace gl | |||
| case internal_format::compressed_rgba_s3tc_dxt3: | |||
| case internal_format::compressed_rgba_s3tc_dxt5: | |||
| return true; | |||
| default: return false; | |||
| @@ -1071,9 +1071,8 @@ namespace rsx | |||
| case rsx::vertex_base_type::s32k: | |||
| case rsx::vertex_base_type::ub256: | |||
| return true; | |||
| default: return false; | |||
| @@ -55,6 +55,7 @@ bool basic_mouse_handler::eventFilter(QObject* target, QEvent* ev) | |||
| case QEvent::Wheel: | |||
| MouseScroll(static_cast<QWheelEvent*>(ev)); | |||
| break; | |||
| default: return false; | |||
Merged
|
Superceded by #3806 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This touches all different parts of the code base, so I'm requesting review from @Nekotekina and @kd-11 , as some assumptions I made may be incorrect, and some of the errors may provide wrong/not enough information.