Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Fixes #3711

Merged
merged 3 commits into from Nov 9, 2017
Merged

rsx: Fixes #3711

merged 3 commits into from Nov 9, 2017

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Nov 8, 2017

#3710 broke github (detects no changes, 0 commits)

  • Disables blit operations if the target will have a size of 0 in any dimension. Fixes blit engine crashing when GPU texture scaling is disabled.
  • Bumps shader cache ver to 1.1. Vertex input declarations (unused since vertex rewrite) and texture sampling coord type (unnormalized vs normalized) no longer affect shader state and do not generate new shaders. Shader cache should generate fewer shaders in affected titles.
  • Do not respect FENCx instructions as they seem to be an optimization hint. Respecting FENCx instructions can result in some hilariously broken shaders including entire shaders that are one big NOP

- Disables blit operations if the target will have a size of 0 in any dimension
- Bumps shader cache ver to 1.1
- This is likely a compiler hint for performance reasons and not a mandate
@Marthgun
Copy link

Marthgun commented Nov 8, 2017

No change in Tales of Graces (skit blur, transparent black lines, half menu background)

accidently deleted log. just heads up for others doing testing, i saw no difference.

@kd-11 kd-11 merged commit 3c9126d into RPCS3:master Nov 9, 2017
@Aske1836
Copy link

Jojo all star battle still has same issues but performance has increased by 1-2fps consistently! Would you know what is causing the inverted shadows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants