improve cellPad [fixes Input regression]

[Megamouse]

fixes Super Street Fighter Turbo 2 HD
similar to prior Catherine fix

also fixes a bug where devices become useless when a "prior" device is disconnected during multiplayer leading to lowered now_connect count

[Kravickas]

FIFA 18 - press start works now

[Luffykun007]

with this PR FIFA World Cup Brazil 2014 going into the game now.

[spyropt]

Super Street Fighter Turbo 2 HD Tested and working again :) thanks

[bobthecooldad]

This fixes the simpsons game stuck at controller reconnect, allows to go ingame
Still has the issue that you cannot go up or down in the menu

[Asinin3]

Simpsons can go ingame on master just need to unplug controller then plug it back in.

Fifa 17 can go ingame with this PR:

Nascar The Game: Inside Line still doesn't respond to inputs.

[SakataGintokiYT]

Ingame with this PR

[tge-was-taken]

BLUS30023 now goes ingame with this PR

[toccata10]

It fixes keyboard input on super street fighter 2, but if I change to an evdev joystick: no input at all. No input neither on my ds4 controller. The config gui shows that these controllers are detected and working. I can create a config file. It's just in the games that they're dead.
The logfile:
RPCS3.log-cellpad.gz

[Megamouse]

@toccata10 try again

[toccata10]

Can't build on my system

[ 78%] Building CXX object rpcs3/CMakeFiles/rpcs3.dir/evdev_joystick_handler.cpp.o
cc1plus: warning: /home/jo/tmp/rpcs3/megamouse/rpcs3_build/rpcs3/cotire/rpcs3_CXX_prefix.hxx.gch : non utilisé parce que « __STDC_CONSTANT_MACROS » est défini [-Winvalid-pch]
/home/jo/tmp/rpcs3/megamouse/rpcs3/rpcs3/evdev_joystick_handler.cpp: Dans la fonction membre « evdev_joystick_handler::EvdevDevice* evdev_joystick_handler::get_device(const string&) »:
/home/jo/tmp/rpcs3/megamouse/rpcs3/rpcs3/evdev_joystick_handler.cpp:237:31: error: pas de fonction concordante pour l'appel à « evdev_joystick_handler::update_device(evdev_joystick_handler::EvdevDevice&, bool) »
  if (!update_device(dev, false))
                               ^
/home/jo/tmp/rpcs3/megamouse/rpcs3/rpcs3/evdev_joystick_handler.cpp:113:6: note: candidate: bool evdev_joystick_handler::update_device(evdev_joystick_handler::EvdevDevice&)
 bool evdev_joystick_handler::update_device(EvdevDevice& device)
      ^~~~~~~~~~~~~~~~~~~~~~
/home/jo/tmp/rpcs3/megamouse/rpcs3/rpcs3/evdev_joystick_handler.cpp:113:6: note:   le candidat attend 1 argument, 2 fourni(s)
make[2]: *** [rpcs3/CMakeFiles/rpcs3.dir/build.make:7727: rpcs3/CMakeFiles/rpcs3.dir/evdev_joystick_handler.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:240: rpcs3/CMakeFiles/rpcs3.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

[Megamouse]

@toccata10 sorry. I forgot a line. I hope it works now

[toccata10]

It works fine now. I tested with evdev, ds4 and keyboard. So the linux part seems ok. Probably just waiting for the merge now.

[Megamouse]

as far as I can tell everything was tested now.
good thing this wasn't merged before (well actually i could've fixed all issues faster then hehe)

[LuismaSP89]

@Megamouse Syberia 2 still has no input even with this PR :S

[Megamouse]

I know. but i can't find the problem. And I don't think I caused it

[toccata10]

Syberia 2 [NPEB02016] has not input problems for me (just tested the beginning) on master. Tested with keyboard and ds4 on windows+linux.

[LuismaSP89]

@toccata10 Strange, i can´t pass the "Press start" screen, and i´m not the only one with this problem as you can see in the issue that i opened:

#3985

Mine is NPEB02016 too, and i tested with keyboard, xbox 360 and xbox one controllers.

[toccata10]

I hope this gets merged soon as it improves master for several games. The syberia 2 pb is already in master, so there's no regression here, just improvement (from what I can see).

[LuismaSP89]

@toccata10 Syberia problem is solved (#3985)