gui: add commit hash to the game panel with non master builds #3993
Conversation
elad335
changed the title
|
|
rpcs3/rpcs3qt/gs_frame.cpp
Outdated
| version = version + "-" + rpcs3::get_branch(); | ||
| } | ||
| //Add branch and commit hash to version on frame , unless it's master. | ||
| version = is_master ? version.substr(0 , version.find_last_of("-")) : version.substr(0 , version.find_last_of(" ")) + " " + rpcs3::get_branch(); |
There was a problem hiding this comment.
this line is not indented correctly
|
Nice addition, it would be certainly useful when people post gaming screenshots related to a PR. Do you think we should have something more consistent between the gs window title (at the top) and the main window title (at the bottom)?
|
|
@scribam maximum the 'v' in the main window should be removed, that should do the trick |
|
Or added in the gs window title 🙂 Doesn't matter which way 😄 What about the branch name? Do you think you can set it like this |
|
yeah 👍 |
|
v in version should remain IMO, |
|
@elad335 Please remove commit count from non-master builds on version, there's a reason I removed it since 0.0.4, it's irrelevant since it's not a master build. Just 0.0.4-d2a2a73 (3993) is fine , or like you have it right now but without commit count |
|
@AniLeo theres a bug that display the build count only on local builds ,ci builds dont display it |
|
It's meant to display on local builds yeah, script only excludes if it's a Pull Request being built via AppVeyor. Maybe add branch name together with version somehow in the same separator, otherwise title bar is starting to look polluted with too much informaton |
|
@AniLeo so remove the commit count from both versions and replace that with the branch name? |
|
You can leave it as is locally |
No description provided.