[WIP] SPU performance optimizations #4108

Farseer2 · 2018-01-25T00:51:08Z

WIP for stability reasons

This PR includes some optimizations, mostly to the SPU, being the current bottleneck of the emulator:

vm::waiters are removed lazily if a lock can't be achieved at the moment of destruction to prevent the threads from locking up too much
Rewrote some heavily used stub so the compiled assembly would be faster (Best example would be try_pop)
Added fast path to try_lock
Code invalidation is only checked if a SYNC instruction was executed
SPU function DB is only searched once (instead of twice). It almost never caught a new function, yet it added quite the long search
Aggressive inlining of some function. While considered bad practice, the compiler didn't do it by itself, and, at worse, the epilogue and prologue of the function took 0.9% runtime while the function itself took 0.1%
Releasing locks earlier when processing mfc commands should reduce the time SPU threads are waiting on locks.
DMA's are now done by a REP MOVSQ, which, at least on Ivy Bridge processors, is faster (Maybe because of the instruction cache having an easier time, idk)
Probably some other stuff I forgot

So, now for the bad parts:

Performance gains may vary - while some reported almost double the FPS, some reported no change at all. Can't think of a reason for that yet.
Some parts were written before kd11 explained some of the SPU stuff to me, so take them with a grain of salt, might affect stability, so if you can, please test and report crashes and the likes.
As TSX has a different flow in some of the edited areas, I couldn't really test it

Thanks to whymsical, haico1992, digitaldude555 and Ani for helping me test this.

tabnk · 2018-01-25T00:57:10Z

Nice :)

Illynir · 2018-01-25T01:59:30Z

It's promising, but it's very unstable for me. Most games freeze without error message or with "F {MFC Thread} MEM: Access violation reading location 0x0" randomly.

That being said I spotted big gains on several games, especially Ni no kuni which becomes fullspeed with OpenGL (before of freeze totally like the others).

Xcedf · 2018-01-25T02:29:22Z

Same situation most game are stoped working, but some are still working
GoW 1/2 HD, Persona 5, House of The Dead Overkill have nice speed boost now

tabnk · 2018-01-25T03:44:25Z

Ni no kuni stuck at loading with Vulkan

greentop · 2018-01-25T04:44:35Z

The gcc build failed on Ubuntu 16.04. (Line 503)
PR 4108 buid.log.gz

M220 · 2018-01-25T05:48:20Z

P5 now have locked 30FPS in sometimes!!!
but RDR now stop in the intro with vulkan and disabling ( or enabling ) thread schedular not helped too ( in openGL it show Rockstar logo but can't go in menu ) ( it's going ingame in master ) and here is the log :
RPCS3_SPU.log.gz
sorry for my bad English 😄

tge-was-taken · 2018-01-25T08:59:23Z

rpcs3/Emu/Cell/SPUASMJITRecompiler.cpp

@@ -121,13 +121,13 @@ void spu_recompiler::compile(spu_function_t& f)
 	compiler.alloc(vec_vars[5], asmjit::x86::xmm5);

 	// Initialize labels
-	std::vector<Label> pos_labels{ 0x10000 };
-	this->labels = pos_labels.data();
+	this->labels = std::unique_ptr<Label[]>(reinterpret_cast<Label*>(new char[0x10000 * sizeof(Label)]()));


use u8 instead of char

tge-was-taken · 2018-01-25T09:00:45Z

rpcs3/Emu/Cell/SPUAnalyser.cpp

@@ -5,16 +5,18 @@

 const spu_decoder<spu_itype> s_spu_itype;

-spu_function_t* SPUDatabase::find(const be_t<u32>* data, u64 key, u32 max_size)
+std::shared_ptr<spu_function_contents_t> SPUDatabase::find(const be_t<u32>* data, u64 key, u32 max_size, void * ignore)


void* ignore contains extra spacing

tge-was-taken · 2018-01-25T09:02:27Z

rpcs3/Emu/Cell/SPUAnalyser.cpp

@@ -33,16 +35,22 @@ SPUDatabase::~SPUDatabase()
 	// TODO: serialize database
 }

-spu_function_t* SPUDatabase::analyse(const be_t<u32>* ls, u32 entry, u32 max_limit)
+std::shared_ptr<spu_function_contents_t> SPUDatabase::analyse(const be_t<u32>* ls, u32 entry, void * ignore /*=nullptr*/)


same as above

spyropt · 2018-01-25T09:14:05Z

On my end all games just crash

cpu x5675 (westmere)
RPCS3.log.gz

tge-was-taken · 2018-01-25T09:04:11Z

rpcs3/Emu/Cell/SPUAnalyser.cpp

@@ -352,7 +366,7 @@ spu_function_t* SPUDatabase::analyse(const be_t<u32>* ls, u32 entry, u32 max_lim
 		m_db.emplace(key, func);
 	}

-	LOG_NOTICE(SPU, "Function detected [0x%05x-0x%05x] (size=0x%x)", func->addr, func->addr + func->size, func->size);
+	LOG_FATAL(SPU, "Function detected [0x%05x-0x%05x] (size=0x%x)", func->addr, func->addr + func->size, func->size);


are you sure this should be fatal? also LOG_* macros are deprecated, see Log.h

tge-was-taken · 2018-01-25T09:05:54Z

rpcs3/Emu/Cell/SPUAnalyser.h


 	// For internal use
-	spu_function_t* find(const be_t<u32>* data, u64 key, u32 max_size);
+	std::shared_ptr<spu_function_contents_t> find(const be_t<u32>* data, u64 key, u32 max_size, void * ignore=nullptr);


spacing, void* ignore = nullptr

tge-was-taken · 2018-01-25T09:08:09Z

rpcs3/Emu/Cell/SPUThread.cpp

-			waiter.stamp = rtime;
-			waiter.data  = rdata.data();
-			waiter.init();
+			vm::waiter * waiter = new vm::waiter();


tge-was-taken · 2018-01-25T09:09:04Z

rpcs3/Emu/Cell/SPUThread.cpp

@@ -1189,28 +1141,33 @@ bool SPUThread::get_ch_value(u32 ch, u32& out)
 			return true;
 		}

-		vm::waiter waiter;
-
+		vm::waiter * waiter = nullptr;


tge-was-taken · 2018-01-25T09:11:28Z

Utilities/mutex.cpp

@@ -173,7 +173,7 @@ void shared_mutex::imp_lock(s64 _old)

 	for (int i = 0; i < 10; i++)
 	{
-		busy_wait();
+		if (i != 0) { busy_wait(); }


braces should be on newlines

tge-was-taken · 2018-01-25T09:11:43Z

Utilities/mutex.cpp

@@ -14,7 +14,7 @@ void shared_mutex::imp_lock_shared(s64 _old)

 	for (int i = 0; i < 10; i++)
 	{
-		busy_wait();
+		if (i != 0) busy_wait();


tge-was-taken · 2018-01-25T09:11:56Z

Utilities/mutex.cpp

@@ -237,6 +237,7 @@ void shared_mutex::imp_lock_degrade()
 bool shared_mutex::try_lock_shared()
 {
 	// Conditional decrement
+	if (m_value < c_min) return false; // Fast path


Farseer2 · 2018-01-25T10:01:18Z

Added CR fixes.
The F {MFC Thread} MEM: Access violation reading location 0x0 repeats in a lot of games - no fix yet, but I'm aware of it, thanks everyone

Farseer2 · 2018-01-25T10:41:40Z

Found the cause for the crashes, will push a fix later today

greentop · 2018-01-25T11:08:00Z

The gcc build did complete for me on Ubuntu as of 6b677b9.

VelocityRa · 2018-01-25T11:42:24Z

@Kravickas This seems related to the known bug, I'd say wait for the fix before posting logs.

raven02 · 2018-01-25T13:12:49Z

P5 boosts quite obvious and nice PR . 1942 Joint Strike also no more lag in-game .

tge-was-taken · 2018-01-25T13:14:50Z

Can confirm, 5-10+ FPS boost in P5 depending on the situation. Haven't been able to test other games yet due to it being very unstable.

GeniusMage · 2018-01-25T13:21:12Z

Eternal Sonata: Transitions are slightly faster, new SPU Halt errors here and there.

Tales of Vesperia: Doesn't start on SPU Recompiler. Has MEM Access Violations on the PPU thread with Interpreter, before reaching the main menu.

Tales of Graces f: Similar issues to Vesperia, it doesn't reach the menu on Recompiler, goes ingame on Interpreter but tends to freeze.

Tales of Xillia: tends to throw a Fatal Error from the start on Recompiler, with no actual message (just a blank window), or just stops before the main menu. Goes Ingame with Interpreter but audio is very choppy.

Tales of Xillia 2: Hangs upon reaching the main menu on Recompiler. Gets stuck before the intro on Interpreter (though it seems like it's still running, it just doesn't do anything).

One thing I've noticed, things go wrong when "Branch-to-next with $LR" happen.

Illynir · 2018-01-25T13:30:26Z

Drakengard 3 ==> Freeze on loading
Ni no kuni ==> + 10 FPS boost on OGL with random freeze, not tested on Vulkan because freeze on loading
Tales of vesperia ==> Freeze sur main menu
Journey ==> +5 FPS, freeze random
Nier/Nier Replicant ==> No difference but this game is special on Windows
Atelier Escha and Logy ==> Freeze on loading.
Tales of graces F ==> Freeze
Persona 5 ==> +5/10 FPS

Xperie · 2018-01-25T13:43:53Z

This has worked really well for P5 I get almost double my fps in some situations and a solid 30 in most areas now. I have one problem thats happened twice where the audio crashes during a load screen and then a few minutes later the game will lock up. I attached the log of what happens.
crashlog.txt

tge-was-taken · 2018-01-25T13:45:39Z

You should probably wait before you start testing games, there's a bad breaking bug that's causing hangs. Some games don't even boot with this.

Lemiru · 2018-01-25T14:03:00Z

Deception IV: The Nightmare Princess - on recompiler freezes after starting new game or continuing and music is missing
The Witch and the Hundred Knight - Freezes on loading screen before menu

Farseer2 · 2018-01-25T14:15:40Z

Closing until I upload the fix, many of these reports are the same problem over and over- thanks everyone

Farseer2 · 2018-01-25T18:55:31Z

So, didn't get to fix it today, so I implemented a quick solution that will degrade performance, just to know if there are other crashes in there.
I'll try to implement the faster solution over the weekend

Illynir · 2018-01-25T19:48:29Z

Quick test with the temporary crash fix:

Drakengard 3: Freeze on loading
Ni no kuni: freeze on loading
Tales of graces F: Freeze on loading

Log show:
E {SPU[0x2000000] Thread (SpursTLGraphicsCellSpursKernel0)} SPU: [0x0504c] Branch-to-next with $LR
E {SPU[0x2000001] Thread (SpursTLGraphicsCellSpursKernel1)} SPU: [0x031a4] Branch-to-next with $LR
E {SPU[0x2000003] Thread (SpursTLGraphicsCellSpursKernel3)} SPU: [0x08844] Branch-to-next with $LR
E {SPU[0x2000004] Thread (SpursTLGraphicsCellSpursKernel4)} SPU: [0x05994] Branch-to-next with $LR
E {SPU[0x2000002] Thread (SpursTLGraphicsCellSpursKernel2)} SPU: [0x04394] Branch-to-next with $LR
E {SPU[0x2000004] Thread (SpursTLGraphicsCellSpursKernel4)} SPU: [0x067d4] Branch-to-next with $LR
E {SPU[0x2000000] Thread (SpursTLGraphicsCellSpursKernel0)} SPU: [0x0494c] Branch-to-next with $LR
E {SPU[0x2000000] Thread (SpursTLGraphicsCellSpursKernel0)} SPU: [0x03344] Branch-to-next with $LR

VelocityRa · 2018-01-25T20:07:08Z

"Branch-to-next with $LR" errors are completely irrelevant.
They're not even "errors" really, just a registers being used in a way that's not standardized. It's not even that unusual, many games do it.
I've suggested making them notices or something, but it didn't happen and I'm certainly not opening a PR just for that.

Illynir · 2018-01-25T20:12:54Z

Well, I don't know, but these messages appear on this PR and not on the Master for me, so I indicate it in case.

If it is useless then the games freeze without displaying any noticeable error message in this case.

Should fix RPCS3#4056

Workaround dirty AVX high state

Use new patterns for saturation instructions Avoid ZExt/SExt completely

Who knows without a linux VM. I sure don't. Only 1 way to find out quickly. Nobody reads these notes anyway ¯\_(ツ)_/¯

Until I find out what else triggers SPU invalidation

Farseer2 · 2018-01-30T19:58:54Z

PR will be closed soon for some maintenance

Luffykun007 · 2018-02-11T02:15:46Z

@Farseer2 reopen please!

Asinin3 · 2018-02-11T05:53:29Z

Why? just because the PR is closed doesn't mean you cant use the builds. (see screenshot below) also I'm guessing he is busy trying to fix it up. It's not ready for a merge yet obviously and closing the PR was probably to help stop spam comments of issues that are known.

mateus-santiago · 2018-08-06T03:01:12Z

How can I actually use this build? Sorry, I'm stupid and new to RPCS3.

tanpro260196 · 2018-08-06T03:52:34Z

Don't use this build. Master already surpass it in term of performance. Just enable debug mode and disable zcull.
And next time please use discord for these type of questions.

tge-was-taken reviewed Jan 25, 2018

View reviewed changes

Farseer2 force-pushed the spu_perf branch from 96d7b7d to fb6d08c Compare January 25, 2018 09:51

Farseer2 closed this Jan 25, 2018

Farseer2 reopened this Jan 25, 2018

Nekotekina and others added 20 commits January 30, 2018 22:05

SPU: 16-bit shifts for AVX2

bb2befa

SPU: use XOP instructions

d1cf21d

Handle exceptions at game list update

5560eeb

Should fix RPCS3#4056

Handle exceptions at loading patch file

b694e28

Initial cpu_translator impl

73cd04e

SPU: emit VZEROUPPER

de1863f

Workaround dirty AVX high state

SPU: rewrite ORX instruction

1e1b1d6

PPU LLVM: rewrite add/sub instructions

90dcaae

Use new patterns for saturation instructions Avoid ZExt/SExt completely

PPU LLVM: rewrite AVG instructions

c154e92

Update LLVM submodule URL

bf12c7c

Add ignore=dirty to hidapi submodule

b2f2f44

Initial optimizations (Squashed to fix submodules)

7cbf1a7

Maybe fix linux build

c65b5a1

Who knows without a linux VM. I sure don't. Only 1 way to find out quickly. Nobody reads these notes anyway ¯\_(ツ)_/¯

Temporary crash fix

1fd1348

Always invalidate code as temp fix

db2d9b8

Until I find out what else triggers SPU invalidation

Performance improvements and CR fixes

092d913

Set log level back to notice

c977c7a

Correct intersection check

043af6b

Some reverting

c7f8a56

Fixup

12897fa

Farseer2 force-pushed the spu_perf branch from fb0e55f to c7f8a56 Compare January 30, 2018 19:57

raven02 added 2 commits January 31, 2018 22:27

Merge branch 'master' into spu_perf

4f12e3a

Merge branch 'master' into spu_perf

4ce0f0e

Farseer2 closed this Jan 31, 2018

Illynir mentioned this pull request Mar 28, 2018

GL/VK: Tales of Vesperia - Rendering issues #2707

Closed

9 tasks

[WIP] SPU performance optimizations #4108

[WIP] SPU performance optimizations #4108

Conversation

Farseer2 commented Jan 25, 2018

tabnk commented Jan 25, 2018

Illynir commented Jan 25, 2018 • edited

Xcedf commented Jan 25, 2018

tabnk commented Jan 25, 2018

greentop commented Jan 25, 2018

M220 commented Jan 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spyropt commented Jan 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Farseer2 commented Jan 25, 2018

Farseer2 commented Jan 25, 2018

greentop commented Jan 25, 2018 • edited

VelocityRa commented Jan 25, 2018

raven02 commented Jan 25, 2018 • edited

tge-was-taken commented Jan 25, 2018

GeniusMage commented Jan 25, 2018

Illynir commented Jan 25, 2018 • edited

Xperie commented Jan 25, 2018

tge-was-taken commented Jan 25, 2018

Lemiru commented Jan 25, 2018

Farseer2 commented Jan 25, 2018

Farseer2 commented Jan 25, 2018

Illynir commented Jan 25, 2018

VelocityRa commented Jan 25, 2018

Illynir commented Jan 25, 2018 • edited

Farseer2 commented Jan 30, 2018

Luffykun007 commented Feb 11, 2018

Asinin3 commented Feb 11, 2018

mateus-santiago commented Aug 6, 2018

tanpro260196 commented Aug 6, 2018 • edited

Illynir commented Jan 25, 2018 •

edited

greentop commented Jan 25, 2018 •

edited

raven02 commented Jan 25, 2018 •

edited

Illynir commented Jan 25, 2018 •

edited

Illynir commented Jan 25, 2018 •

edited

tanpro260196 commented Aug 6, 2018 •

edited