New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented sysCacheClear() #4445
Changes from 1 commit
ecc0cd5
11522bc
7919122
0efa6c9
13334f1
3b6ba7e
472e233
d20c7b5
243816d
b20f750
5988d5f
0b33e0c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -285,21 +285,16 @@ s32 cellSysutilUnregisterCallback(u32 slot) | |
|
||
s32 cellSysCacheClear() | ||
{ | ||
// Checks if the param exists, else we quit | ||
|
||
if (!fxm::check<CellSysCacheParam>()) | ||
{ | ||
return CELL_SYSCACHE_ERROR_NOTMOUNTED; | ||
} | ||
|
||
// Get the param as a shared ptr, then decipher the cacheid from it | ||
// (Instead of assuming naively that the param is passed as argument) | ||
std::shared_ptr<CellSysCacheParam> param = fxm::get<CellSysCacheParam>(); | ||
|
||
cellSysutil.todo("cellSysCacheClear()"); | ||
|
||
// Unit test for param ptr, since it may be null at the time of get() | ||
if (!param) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's pretty much NOTMOUNTED error, fxm::check becomes unnecessary. |
||
{ | ||
return CELL_SYSCACHE_ERROR_ACCESS_ERROR; | ||
return CELL_SYSCACHE_ERROR_NOTMOUNTED; | ||
} | ||
|
||
const std::string& cache_id = param->cacheId; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you still need to check for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We do that check above in
and This check was already part of the repo beforehand so I didn't change it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But I told you to... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't bind references, it's old style. |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use
warning
log type instead oftodo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also.. put it in the beginning of the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright