Better Support For Game Collections

[Megamouse]

Hereby I attempt to enable the usage of PS3_GM01, PS3_GM02 etc in the gamelist, by adding a new emu member m_game_dir and using this instead of PS3_GAME.
The granularity of games.yml had to be increased.
Also the addition of games to the games.yml by BootGame(add_only) was extended.

aims to fix #4448

[JMC47]

Fixes Disgaea Triple Play Collection in the gamelist.

Allows the selection of Disgaea 4 and D2. Also fixes the banners showing up in the gamelist.

Unfortunately, there are severe issues as the games will still look for important files within the PS3_GAME folder, causing them to crash.

E {PPU[0x100000c] Thread (fios mediathread 11) [0x02b44090]} 'sys_fs_open' failed with 0x80010006 : CELL_ENOENT, “/dev_bdvd/PS3_GAME/USRDIR/Data/SOUND/SndPak.pak” [1]

I figured I'd clarify exactly what the game is doing since I reread my post and it was a bit unclear.

The ISO has three folders within the game folder.

PS3_GAME
PS3_GM01
PS3_GM02

All three of these are stand-alone games that I can be used as individual ISOs. So if I were to split off GM01 into it's own folder as a "PS3_GAME" folder, RPCS3 will see it as a game and it'll load/function correctly. While this works if you want to play the games, I'd rather the game work out of the box for other users if possible. Because GM01 is more or less it's own game, the fact that RPCS3 is having the game search for files in the GAME folder is incorrect.

[Megamouse]

I changed it to use a different approach. maybe this time the games can function properly?

[JMC47]

The other two games are still searching in PS3_GAME path for some things. Here's an example with the GM01 (Disgaea 4)

E {PPU[0x1000013] Thread (_cellsurMixerMain) [0x003b1530]} 'sys_mutex_lock' failed with 0x80010008 : CELL_EDEADLK [3]
E {PPU[0x100000c] Thread (fios mediathread 11) [0x02b44090]} 'sys_fs_open' failed with 0x80010006 : CELL_ENOENT, “/dev_bdvd/PS3_GAME/USRDIR/Data/SOUND/SndPak.pak” [1]
E {PPU[0x1000013] Thread (_cellsurMixerMain) [0x003b1970]} Stat: '_sys_lwmutex_lock' failed with 0x80010005 : CELL_ESRCH [x3256]
E {PPU[0x1000013] Thread (_cellsurMixerMain) [0x003b1970]} Stat: 'sys_mutex_lock' failed with 0x80010008 : CELL_EDEADLK [x814]
E {PPU[0x1000011] Thread (_sys_MixerChStripMain) [0x003b5eec]} Stat: '_sys_lwmutex_lock' failed with 0x80010005 : CELL_ESRCH [x6512]

[JMC47]

I should note that the latest version of this PR does fix the issues completely.

[HHCHunter]

Is there a reason this PR is still open? I thought I had read about this being merged at some point 🤔

[Megamouse]

@JMC47 I had to rework this, because the old implementation was outdated.
Can you please test again if everything still works?

Things to test:
Adding games to the list, playing the games, games stay in the list on next time you open RPCS3 and so on

[JMC47]

All three games boot and work through their intro. The games remain in the gamelist after closing.

I guess I'll note that in order to add the second/third games in the collection, you have to navigate into the PS3_GM01 and PS3_GM02 folders - just adding the top folder will only add the PS3_GAME game. I'm guessing that's intended, but, it is a bit weird not to be able to add all three at once.

[Megamouse]

Please delete your games.yml and drop the single game folder again. Then upload games.yml and the log

[JMC47]

Alright, retested it and redid it.

games.zip