minor dialog fixes #4709
Merged
minor dialog fixes #4709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
force-pushed
the
minor_fixes
branch
9 times, most recently
from
931b074
to
ec24b9e
Compare
kd-11
reviewed
Jun 8, 2018
rpcs3/Emu/RSX/GSRender.h
Outdated
| @@ -69,6 +69,11 @@ class GSFrameBase | |||
| virtual void hide() = 0; | |||
| virtual void show() = 0; | |||
|
|
|||
| // taskbar progress | |||
| virtual void progress_reset() = 0; | |||
There was a problem hiding this comment.
This is unnecessary. These methods belong to the GSFrame implementation, only the core stuff should be in the frame base class (i.e, it is not necessarily true that the implementation has support for taskbar progress at all). It will work just fine once you remove the override specifier in the implementation class (gs_frame).
There was a problem hiding this comment.
True. This was a remnant of my earlier implementation.
and clean up a bit
kd-11
approved these changes
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Qt Dialog progress bars never reaching 100%.
Switches weird progressvalue int pointer to int.
Handle file access error in cellSaveData by returning an error.
Remove old code for the ppu compile wall of dialogs.
Add taskbar progress to all progressbar dialogs (Qt dialog AND native UI).