Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spu-precise: fix double-precision floating-point exception checks #4884

Merged
merged 2 commits into from Jul 20, 2018
Merged

spu-precise: fix double-precision floating-point exception checks #4884

merged 2 commits into from Jul 20, 2018

Conversation

scribam
Copy link
Contributor

@scribam scribam commented Jul 15, 2018

Copy link
Contributor

@elad335 elad335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original intention was to read the mxcsr register once and use its value to determine the exception flags raised. If the values being used are wrong, fix them instead.

@scribam
Copy link
Contributor Author

scribam commented Jul 15, 2018

Thanks for the review. PR updated with your recommendation.

@Nekotekina Nekotekina merged commit 5828367 into RPCS3:master Jul 20, 2018
@scribam scribam deleted the spu-precise branch July 20, 2018 12:03
@stan0danny
Copy link

stan0danny commented Jul 20, 2018

i'm afraid, i saw rpcs3 update is infamous 2009 before fps 2.45 - 5,10 and after fps 0.43 , my laptop nvidia 940m 2gb , i7 5500u , ram 16 gb . you fixing rpcs3 sometime ?

@AniLeo
Copy link
Member

AniLeo commented Jul 20, 2018

Precise modes are not meant to have playable speeds.

@stan0danny
Copy link

ohhh :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants