New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup (shared_mutex, named_thread); fix cellVdecClose #5173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekotekina
force-pushed
the
master
branch
3 times, most recently
from
September 25, 2018 19:57
1c1b706
to
dd19654
Compare
Rewrite to use unsigned arithmetic, shrink to u32 Ensure zero default unlocked state (will need it later) Inline all public methods, rewrite lock_upgrade() Remove try_lock_degrade(), lock_degrade() methods Implement lock_downgrade() (now trivial) Remove is_reading(), added is_free() Added reader_lock::try_upgrade()
lf_queue<>: unbound FIFO queue with dynamic linked-list lf_value<>: concurrently-assignable value readable without locking at the cost of memory (using dynamic linked list) Add atomic_t<>::compare_exchange
Writable sections ARE supported
Don't clear force_boot on shortcut Load()
Thanks Micaelis#6971
Old class named_thread renamed to old_thread It's too hard to move in a single commit
The only user that marge the pr with (WIP) Tag. |
So? |
What's the problem? Regression? |
Nekotekina
changed the title
[WIP] Cleanup
Cleanup (shared_mutex, named_thread); fix cellVdecClose
Sep 27, 2018
@Nekotekina @AniLeo it just for fun :) |
It sounded hostile, that's why so many people reacted with thumbs down. But yeah, this happens all the time, communication through text, language barrier etc. Good to see that all was in good spirit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.