rsx: Texturing improvements followup #5726
Conversation
…tion/stubs for blit engine rotations in GPU
- Assumption here is that only texel (0, 0) is accessible. Inline with other pitch 0 operations. - TODO: Verify pitch 0 does not advance in Y either
- Figured out why it breaks things, ofc can't actually check for coverage when there is no proper fbo data persistence
- Properly wait for the buffer transfer operation to finish before map/readback! - Change vkFence to vkEvent which works more like a GL fence which is what is needed. - Implement supporting methods and functions - Do not destroy fence by immediately waiting after copying to dma buffer
- The section needed starts at image origin, not transfer origin!
- Properly pass parameters such as rsx-pitch to the surface store - Do not crash if a surface fails verification in flip, use fall-back instead
- Batch dma transfers whenever possible and do them in one go - vk: Always ensure that queued dma transfers are visible to the GPU before they are needed by the host Requires a little refactoring to allow proper communication of the commandbuffer state - vk: Code cleanup, the simplified mechanism makes it so that its not necessary to pass tons of args to methods - vk: Fixup - do not forcefully do dma transfers on sections in an invalidation zone! They may have been speculated correctly already
|
Ninja Gaiden Sigma 1 regression fixed in this PR, thank you! |
|
Supersonic Acrobatic Rocket-Powered Battle-Cars no longer requires CPU blit |
|
Beyond Two Souls no longer needs CPU blit for proper textures. Before: |
Regression is gone and it's playable
still has a Regression Monster Jam: Path of Destruction [BLUS30561]
|
|
DeS black flicker seems fixed- haven't encountered it in the last hour |
|
H.A.W.X can now go ingame without the need for CPU Blit. OpenGL can get ingame but has issues, while Vulkan can't get ingame at all. OpenGL IssuesThe game manages to get ingame but suffers from weird texture corruption that only appears ingame: Please let me know if there is any more information you would like me to supply. Vulkan IssuesAs the shaders are being compiled right before it would enter ingame, the screen freezes and spams the log with |
This comment has been minimized.
This comment has been minimized.
|
Beyond Two Souls also had an issue where cpu blit would make the colors look correct but when you using your ability the environment can randomly turn black. Since this PR makes it so you only need WCB now both look correct. Before WCB only: |
A follow-up to the last PR addressing a few issues
Tracker: #5708