Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort alphabetically the languages combo box in the system settings #5840

Merged
merged 3 commits into from
Apr 14, 2019
Merged

Sort alphabetically the languages combo box in the system settings #5840

merged 3 commits into from
Apr 14, 2019

Conversation

vieiraa
Copy link
Contributor

@vieiraa vieiraa commented Apr 13, 2019 •
edited
Loading

Fixes #5838

@MSuih
Copy link
Member

MSuih commented Apr 14, 2019

If you are not going to sort the is_ranged codepath then I think you should at least print a message to log which states that it won't get sorted when sorted is set to true. That way you someone else doesn't have to debug why their sort request is not working.

Other than that, this looks okay. The number of arguments is getting kind of long, but I think it's still acceptable.

@vieiraa
Copy link
Contributor Author

vieiraa commented Apr 14, 2019

It seems to me that the ranged ones are always sorted. So I will just print that log message then.

@AniLeo AniLeo added the GUI label Apr 14, 2019
@Nekotekina Nekotekina merged commit f995771 into RPCS3:master Apr 14, 2019
@vieiraa vieiraa deleted the sort_lang branch April 14, 2019 16:34
@k10kan k10kan mentioned this pull request Apr 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort console language
4 participants
@vieiraa @MSuih @Nekotekina @AniLeo