Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings cleanup #5964

Merged
merged 11 commits into from Jun 27, 2019
Merged

Warnings cleanup #5964

merged 11 commits into from Jun 27, 2019

Commits on Jun 26, 2019

  1. CMake refactor

    @JohnHolmesII
    JohnHolmesII committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    27fca2e View commit details
    Browse the repository at this point in the history

  2. asmjit cleaned up their cmake warnings (no code change)

    @JohnHolmesII
    JohnHolmesII committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    1fcf62f View commit details
    Browse the repository at this point in the history

  3. Disable warnings for stb_image.cpp. Should this file be moved to 

    3rdparty?
    @JohnHolmesII
    JohnHolmesII committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    32f8f40 View commit details
    Browse the repository at this point in the history

  4. Fix warnings related to parentheses

    @JohnHolmesII
    JohnHolmesII committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    be521ff View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. Fix warnings related to -Wswitch 

    Add default cases.
Move default breaks to newline
Add proper handling in some instances.
Add missing enums to switches
    @JohnHolmesII @Nekotekina
    JohnHolmesII authored and Nekotekina committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    23094b4 View commit details
    Browse the repository at this point in the history

  2. Properly ignore SIMD macros to avoid warning

    @JohnHolmesII @Nekotekina
    JohnHolmesII authored and Nekotekina committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    ebb1ae6 View commit details
    Browse the repository at this point in the history

  3. Explcitly mark overflow in various SIMD functions. Doing so silently 

    created warnings.
    @JohnHolmesII @Nekotekina
    JohnHolmesII authored and Nekotekina committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    2291708 View commit details
    Browse the repository at this point in the history

  4. Fix -Wsign-compare a little bit 

    Explicitly mark loop types (per review)
    @JohnHolmesII @Nekotekina
    JohnHolmesII authored and Nekotekina committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    d0eae7b View commit details
    Browse the repository at this point in the history

  5. Remove braces around shader source strings (warnings)

    @JohnHolmesII @Nekotekina
    JohnHolmesII authored and Nekotekina committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    a124ec4 View commit details
    Browse the repository at this point in the history

  6. Remove unecessary vulkan loader check var, per kd

    @JohnHolmesII @Nekotekina
    JohnHolmesII authored and Nekotekina committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    948c1df View commit details
    Browse the repository at this point in the history

  7. Various small warning fixes 

    -Indentation warnings
-prevent shift overflow
-This was declared extern in all contexts. Remove this for initialization
-Fix main return types. OH CANADA!
-Silence extraneos 'unused expression' warning
-Force use return value (warning)
-Remove tautological compare copy-pasta (char always < 256)
    @JohnHolmesII @Nekotekina
    JohnHolmesII authored and Nekotekina committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    232a35b View commit details
    Browse the repository at this point in the history