Fix build with cotire and clang-8.0 branch #6169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't need to check If CMake is older than some really ancient version because we already require 3.8.2 and higher due to C++17 compatibility |
|
I always wondered what this PCH header error was. I just removed cotire locally for my builds without bothering to fix this. It works now with cotire 😄 |
Without this patch, build fails when using cotire, because pch headers are missing the pthread flag when using Clang
Removed and squashed into previous commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, build fails when using
cotire, because pch headers are missing
the pthread flag when using Clang