Qt: Fall back to VERSION in game list #6383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to the dev wiki, VERSION is used for rereleases of the same content (f.ex. platinum versions of the game or issuing a fixed version of a previous update) while APP_VERSION is used for actual update version numbering. I'm guessing that they originally only had one version number and the other one was added later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older games do not seem to have an APP_VERSION set in their PARAM.SFO which led to "Unknown" in the game list.
We now fall back to the VERSION in these cases.
It would be interesting to know the relationship between VERSION and APP_VERSION and if there is some deeper logic behind them.