sys_cond_wait: Wait for rescheduling before relocking #6405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elad335 This PR(6405) is huge retrogression ! Dynasty warriors:Gundam Reborn[NPUB31531] & Gundam breaker 2[BLAS50770] are freezing ,can not ingame. And no any error message! Other games haven't been tried yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the thread to be scheduled before relocking the mutex, this matches with the kernel because it needs to be reschedulef before taking any action.
Can solve potential deadlocks whenever the waiting thread is still waiting for the scheduler yet other threads attempting to acquire the mutex.
Edit: it is also required for accurate ETIMEOUT checking, as on ps3 kernel the waiting thread needs to confirm condition not met after the amount of time specified, which means it needs to be scheduled beforehead.