cellScreenshot: initial implementation #6668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
commented
Sep 29, 2019
Megamouse
commented
Sep 29, 2019
Megamouse
force-pushed
the
cellScreenshot
branch
from
5e72c5e
to
609c817
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Megamouse
force-pushed
the
cellScreenshot
branch
from
609c817
to
1d224d4
Compare
Megamouse
commented
Sep 30, 2019
| @@ -308,63 +313,102 @@ void gs_frame::flip(draw_context_t, bool /*skip_frame*/) | |||
| void gs_frame::take_screenshot(const std::vector<u8> sshot_data, const u32 sshot_width, const u32 sshot_height) | |||
| { | |||
| std::thread( | |||
| [sshot_width, sshot_height](const std::vector<u8> sshot_data) { | |||
There was a problem hiding this comment.
this is basically all formatting from spaces to tabs
Megamouse
commented
Sep 30, 2019
|
|
||
| const auto fxo = g_fxo->get<screenshot_manager>(); | ||
|
|
||
| if (fxo->is_enabled) |
There was a problem hiding this comment.
additional code starts here
Megamouse
force-pushed
the
cellScreenshot
branch
2 times, most recently
from
84713b7
to
196e35f
Compare
Megamouse
force-pushed
the
cellScreenshot
branch
from
196e35f
to
d31c1ca
Compare
elad335
reviewed
Oct 9, 2019
Megamouse
force-pushed
the
cellScreenshot
branch
from
d31c1ca
to
64f7c7f
Compare
Megamouse
force-pushed
the
cellScreenshot
branch
from
64f7c7f
to
7fe3686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the basic setup of the cellScreenshot utility.
This includes enabling/disabling screenshots, getting the desired screenshot name and metadata, as well as receiving the optional overlay image information.
This is connected to the existing rpcs3 screenshot shortcut and creates a second screenshot in "/screenshots/cell/".
It will only create the second screenshot if the game enabled it.
TODOs:
The overlay is not yet added to the screenshot (if one was specified).
The filenames are not incrementing yet.