rsx: Explicity describe transfer regions for both source and destination blocks #6693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to historical design decisions, transfer descriptors had to be based on one of the two surfaces, source or destination, even in cases where it made no sense to do so. When adding in some new functionality, this problem became very obvious as the descriptors are clearly rebased inconsistently. This commit explicitly defines two separate regions for the incoming and outgoing surfaces, making things much easier to work with. An optional transform descriptor is included to make porting old logic easier.
Some incoming new functionality relies on this working correctly, so I'd like to get it set up for extensive regression testing. Might also fix some strange texture cache bugs introduced in the new texture cache.