Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Explicity describe transfer regions for both source and destination blocks #6693

Merged
merged 1 commit into from Oct 4, 2019

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Oct 3, 2019

Due to historical design decisions, transfer descriptors had to be based on one of the two surfaces, source or destination, even in cases where it made no sense to do so. When adding in some new functionality, this problem became very obvious as the descriptors are clearly rebased inconsistently. This commit explicitly defines two separate regions for the incoming and outgoing surfaces, making things much easier to work with. An optional transform descriptor is included to make porting old logic easier.
Some incoming new functionality relies on this working correctly, so I'd like to get it set up for extensive regression testing. Might also fix some strange texture cache bugs introduced in the new texture cache.

@osmos1

This comment has been minimized.

@kd-11
Copy link
Contributor Author

kd-11 commented Oct 3, 2019

Unlikely to be caused by the change itself in this case. The commit does not touch synchronization or anything that would change performance, just sizes of some textures.

@kd-11 kd-11 changed the title [TESTERS NEEDED] rsx: Explicity describe transfer regions for both source and destination blocks rsx: Explicity describe transfer regions for both source and destination blocks Oct 4, 2019
@kd-11 kd-11 merged commit 4a19a2d into RPCS3:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants