Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cellGemUpdateStart/Finish error checking improved #6705

Merged
merged 2 commits into from Oct 8, 2019
Merged

cellGemUpdateStart/Finish error checking improved #6705

merged 2 commits into from Oct 8, 2019

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Oct 4, 2019 •
edited

  • camera_frame = NULL is now checked for CELL_GEM_NO_VIDEO (applied both on start and finish)
  • camera_frame = NULL on Start() still starts the update.
  • Implemented NOT_FINISHED/STARTED checks.

All of those were reversed and hw tested.

Other improvements:

  • Fixed a verification failure when stopping the emulation regarding cond variable's mutex ownership.

@elad335 elad335 force-pushed the mhmm branch 4 times, most recently from 587e001 to 76205f4 Compare October 4, 2019 17:19
@elad335 elad335 changed the title Minor bugfixes [WIP] Minor bugfixes Oct 4, 2019
@elad335
cellGemUpdateStart/Finish error checking improved
dd086e5 
* camera_frame = NULL is now checked for CELL_GEM_NO_VIDEO (applied both on start and finish)
* camera_frame = NULL on Start() still starts the update
* Implemented NOT_FINISHED/STARTED

All of those were reversed and hw tested.
@elad335 elad335 changed the title [WIP] Minor bugfixes cellGemUpdateStart/Finish error checking improved Oct 4, 2019
@elad335
Copy link
Contributor Author

elad335 commented Oct 4, 2019

Heres the testcase https://github.com/elad335/myps3tests/tree/master/ppu_tests/cellCameraUpdateStart.

@elad335 elad335 force-pushed the mhmm branch 7 times, most recently from 3fec6f3 to e6267eb Compare October 5, 2019 07:06
@Nekotekina Nekotekina merged commit 0f3c5f9 into RPCS3:master Oct 8, 2019
@elad335 elad335 deleted the mhmm branch October 8, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Firmware: HLE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elad335 @Nekotekina @Megamouse