Make windows_file::stat return the same mtime as fs::stat #6708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSuih
reviewed
Oct 5, 2019
| @@ -966,7 +966,7 @@ fs::file::file(const std::string& path, bs_t<open_mode> mode) | |||
| info.is_writable = (basic_info.FileAttributes & FILE_ATTRIBUTE_READONLY) == 0; | |||
| info.size = this->size(); | |||
| info.atime = to_time(basic_info.LastAccessTime); | |||
| info.mtime = to_time(basic_info.ChangeTime); | |||
| info.mtime = to_time(basic_info.LastWriteTime); | |||
| info.ctime = info.mtime; | |||
There was a problem hiding this comment.
Could you change ctime so that it still keeps using ChangeTime? The mtime change looks to be correct but ctime should still be ChangeTime in my opinion.
Edit: Or I guess not.
|
Im not sure if it is same problem, but Conan also reinstallating with every execution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason these two functions should return different mtime on windows, and also ChangeTime cannot be influenced by fs_utime, only LastWriteTime can.
This fixes MGS4 disc versions always deleting stage dat files on boot because mtime doesnt match expected (set by fs_utime) on windows, forcing a chapter reinstall every boot.