spu-disasm Improvement, sys_cond Fix, More verbose logging for TrophyRegisterContext #6772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Oct 15, 2019
•
elad335
commented
- Logging improvements for failed sceNpTrophyRegisterContext call with ILLEGAL_TROPHY error.
- interrupts disable/enable SPU bits status is now shown on instruction name.
- Wait a little longer for possible sys_mutex_unlock() after confirming signal by checking cond.sq, yet the ownership has yet to pass.
- Allow options = 1 on sceNpTrophyCreateContext.
That's how the assembler represents it as well.
elad335
changed the title
…DATE error Also use safer checking when creating trophy ctxt dir
…ership immediatly
options = 1 is allowed.
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Oct 16, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Oct 16, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Oct 16, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Oct 16, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Oct 16, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Oct 16, 2019
Nekotekina
pushed a commit
that referenced
this pull request
Oct 16, 2019
kd-11
pushed a commit
to kd-11/rpcs3
that referenced
this pull request
Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.