avoid update of window title

[plappermaul]

only update the window title if user really wants to display the FPS during gameplay. Additionally wait some frames for better low FPS averages.

[Megamouse]

Sorry but ... Just no

[plappermaul]

Hm? Why do we refresh the game title twice a second with inactive FPS display?

[Megamouse]

Because we want to know if the setting changed. You may use some check to find out if the current configuration changed from true to false and then update it once. Then it would be fine. But with the current PR it will never remove the fps counter.

And the arbitrary 5 frame check doesn't seem right

[plappermaul]

Maybe I'm too stupid ...

I reverted to master: Running on Linux I cannot change the parameter on the fly. Either the game starts with the FPS counter and everything is fine or it starts without. Changing the parameter during gameplay does not give any effect. Same goes for settings like vsync.

So the patch behaves as desired or do you expect something else?

[Megamouse]

You cannot change it on the fly at the moment.
But your change breaks it once it's possible.

[plappermaul]

Got it, changed it.

[plappermaul]

Simplified the patch for better readability.

[elad335]

You don't need to use get() method for the config value, theres an implicit conversion to bool iirc.

[Megamouse]

I forgot. Could you please add a comment next to the member declaration that explains its purpose? That way noone removes it unknowingly in the future.

[plappermaul]

done

[Megamouse]

I meant the cfg changes ;)
I'll just add a few words in my next PR