Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug build gcc/clang linker. #6814

Merged
merged 2 commits into from Oct 24, 2019

Conversation

Niram7777
Copy link
Contributor

Create temporary variable to resolve undefined reference.

[ 98%] Linking CXX executable ../bin/rpcs3
/usr/bin/ld : Emu/librpcs3_emu.a(sys_vm.cpp.o) : dans la fonction « sys_vm_t::~sys_vm_t() » :
/mnt/raid/Git/rpcs3/rpcs3/Emu/Cell/lv2/sys_vm.cpp:21 : référence indéfinie vers « id_manager::id_traits<sys_vm_t, void>::invalid »
collect2: erreur: ld a retourné le statut de sortie 1
make[2]: *** [rpcs3/CMakeFiles/rpcs3.dir/build.make:426: bin/rpcs3] Error 1

Marin Baron and others added 2 commits October 20, 2019 21:33
Create temporary variable to resolve undefined reference.

[ 98%] Linking CXX executable ../bin/rpcs3
/usr/bin/ld : Emu/librpcs3_emu.a(sys_vm.cpp.o) : dans la fonction « sys_vm_t::~sys_vm_t() » :
/mnt/raid/Git/rpcs3/rpcs3/Emu/Cell/lv2/sys_vm.cpp:21 : référence indéfinie vers « id_manager::id_traits<sys_vm_t, void>::invalid »
collect2: erreur: ld a retourné le statut de sortie 1
make[2]: *** [rpcs3/CMakeFiles/rpcs3.dir/build.make:426: bin/rpcs3] Error 1
@Niram7777 Niram7777 marked this pull request as ready for review October 20, 2019 19:48
@Niram7777
Copy link
Contributor Author

I will open a ticket to gcc/clang teams. (maybe more relevant/cleaner)

@Nekotekina Nekotekina merged commit 4599d58 into RPCS3:master Oct 24, 2019
@danilaml
Copy link
Contributor

danilaml commented Oct 24, 2019

Not sure if it's a bug. Looks awfully similar to ODR violation, i.e. something like this case. Could likely be fixed by making id_traits static fields constexpr.

@Niram7777 Niram7777 deleted the undefined_reference_id_traits branch November 17, 2019 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants