Update cellVoice.cpp #6857
Update cellVoice.cpp #6857
Conversation
|
the intention was to compare if equals to 0. |
|
Uh, yes I could tell that there was a comparison to 0. I'm saying I am as uncertain as the compiler is what was supposed to be compared to 0, and which state was supposed to return an error. Consider each of the 3 These 3 read very differently (and some give warnings). The way I read the code, it seemed to me that it was a simple return code check, so I patched it as such. If I misinterpreted, and the function returning 0 is an error, then the condition will need to be inverted. |
Caused warnings. Not sure what the actual intention was, this may need to be inverted. This commit assumes that erase() returning 0 is a sign that deletion failed, or that there was corruption. There should be a port there.
|
I think the last push makes more sense, having looked at the docs for erase() |
|
As far as I understood topology is returned if no port with such ID was registered. So if n erased is 0 it should be an error ?! |
|
yes |
Caused warnings. Not sure what the actual intention was, this may need to be inverted.