Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPU LLVM: rewrite comparison on non-xfloat path of CFLTU, CFLTS #6872

Merged
merged 1 commit into from Dec 30, 2019

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Oct 25, 2019

There was a typo with float comparison type (unordered makes negative Nan result to true, writing -1 instead of 0) in CFLTU.
While also make CFLTU on non-xfloat path accurate as xfloat path now.

Other improvements:

  • optimize PPU FCTIW. (unoptimized form was given from thought of non-existing corner case)

@Xcedf
Copy link

Xcedf commented Oct 25, 2019

This PR fixes one hidden issue, normaly it's not an issue on master, but on custom build if i use
non-accurate or approximate version of FMA with non-accurate version of FM i see this in TLoU
2
now fixed
1

CFLTU on non-xfloat path is accurate as xfloat path now.
* Also optimize FCTIW like FCTIWZ (PPU)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants