Stop building ALSA/PulseAudio/FAudio when disabled #6908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkmauve
force-pushed
the
optional-audio-backends
branch
3 times, most recently
from
d08e027
to
386ff8e
Compare
|
Disabling OpenAL currently doesn't make sense. I recommend removing this commit. |
|
Why doesn’t it? |
|
Because changes in cellMic are too intrusive for it. And why would you want to disable it in the first place? |
|
I agree. It makes no sense to remove it. And littering the code with unnecessary ifdefs is not encouraged. |
|
Especially if you're gonna spam the log with error messages after you already intentionally disabled it XD |
Nekotekina
force-pushed
the
optional-audio-backends
branch
2 times, most recently
from
9fa322e
to
fdc834d
Compare
Nekotekina
force-pushed
the
optional-audio-backends
branch
from
fdc834d
to
03a2d36
Compare
Nekotekina
changed the title
|
Rebased and merged partially. |
|
Thanks. :) |
Megamouse
added
the
Build and CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mirrors 9253f7d, in that it stops building audio backends which are disabled.
It also allows the user to disable OpenAL at build-time like other audio backends, this disables microphone input at the same time.
This PR is more easily read commit per commit.