Fixed plurals of time played #6937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For anyone who was wondering why there need to be so many cases:
|
Margen67
reviewed
Nov 2, 2019
| @@ -383,7 +383,12 @@ QString game_list_frame::GetPlayTimeBySerial(const QString& serial) | |||
| const qint64 hours_played = elapsed_seconds / 3600; | |||
| const qint64 minutes_played = (elapsed_seconds % 3600) / 60; | |||
| const qint64 seconds_played = (elapsed_seconds % 3600) % 60; | |||
|
|
|||
|
|
|||
| // For anyone who was wondering why there need to be so many cases: | |||
There was a problem hiding this comment.
"For anyone who was wondering why so many cases are needed:"? Kappa
|
FWIW even this doesn't exhaust the list of possible plurals for some non-English languages, but I don't know how this could be handled more gracefully. |
|
Couldn't this have been done in a plural agnostic way in the first place? e.g. "Time played: 5H 16M" or something similar? The amount of extra coded needed just obfuscates everything. Use an ISO time format or something. |
|
Every launcher uses something readable |
Right, which is why my proposal is excellent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.