Switch gsl::span from GSL to tcbrindle’s implementation #6970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gsl::narrow can be replaced with ::narrow |
linkmauve
force-pushed
the
switch-gsl-tcb
branch
3 times, most recently
from
3a1721a
to
a4422e4
Compare
|
Any idea how to fix the Windows build? |
|
Must be missing include path. |
linkmauve
force-pushed
the
switch-gsl-tcb
branch
from
a4422e4
to
a9ca51c
Compare
This implementation optimises correctly on all relevant compilers, unlike GSL’s which gave extremely slow code on any compiler other than MSVC. Supersedes RPCS3#6948.
GSL’s gsl::span didn’t use the correct type for its index_type, which is why they were needed.
This is completely untested, as I can’t run Visual Studio.
|
This should be good to go, thanks. :) |
kd-11
reviewed
Nov 9, 2019
linkmauve
force-pushed
the
switch-gsl-tcb
branch
from
a9ca51c
to
56f82d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
std::copy()(and maybe other functions) generate optimal code on all compilers, instead of just MSVC.Here are comparisons of both implementations (toggle the compiler used at the top-left of the right pane):
With GSL: https://godbolt.org/z/FtnK52
With tcbrindle: https://godbolt.org/z/8_JA5d
As we can see, there is no regression on MSVC, but now both gcc and clang are able to generate
memmove()calls.This also lets us drop the GSL dependency altogether.
Closes #6948.