rsx/vk: Implement dynamic sized memory heaps #6972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: My comment in the description was maybe not clear enough, performance loss may happen with the current setup, but that is only because I made allocations too small on purpose for testing. More concerned with stability or lack thereof for the moment. |
|
Seems to fix Bayonetta. |
kd-11
force-pushed
the
rsx_volatile
branch
2 times, most recently
from
1f74c53
to
f8d9c72
Compare
kd-11
changed the title
- The heaps will grow as desired, no need to overallocate to cater to the most resource-hungry games
- The spec does not guarantee that queries are initialized. In fact, it now says all queries must be reset before they are used for the first time.
- Avoid referencing the old buffer in stale views. Status can be set globally if requested during heap creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the data upload heaps growable which should avoid running out of memory. The old approach was that if the runtime did not predict running out of memory early enough, the allocator would crash with a "working buffer not big enough" error. Now, if there is an out-of-memory event, the heap is garbage collected and a new one takes its place transparently. The last commit in the sequence drastically lowers memory allocation sizes to trigger the out-of-memory condition easier in sensitive games and will be tweaked before merge.
Fixes #3343