Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow NaN in cellVideoOutSetGamma #6997

Merged
merged 1 commit into from Nov 16, 2019

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Nov 15, 2019

This matches the firmware as it errors if gamma NGE 0.8 (Not Greater Equal Than).

@kd-11
Copy link
Contributor

kd-11 commented Nov 15, 2019

While this disallows nan, its obviously by accident and makes the code less readable for no gain (nobody is going to call setgamma with NaN). As a concession, just invert the whole condition whether it matches firmware or not. I still think its not actually useful though.

@elad335
Copy link
Contributor Author

elad335 commented Nov 15, 2019

Done, can also use std::isnan for readability but it currently seem redundent.

@elad335
Copy link
Contributor Author

elad335 commented Nov 16, 2019

Also fixed error checking order.

@kd-11 kd-11 merged commit 0f2adab into RPCS3:master Nov 16, 2019
@elad335 elad335 deleted the cellVideoOutSetGamma branch November 16, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants