New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsx: Make X11 optional on Linux #7018
Conversation
Builds just fine on X11 |
there any different between pure Wayland and X11 or XWayland build ? |
So, Wayland is a protocol, X11 is a protocol. Xwayland is a build of the Xorg server allowing you to run any X11 program on a Wayland compositor. This PR only makes it so a user using only Wayland can build rpcs3 without having to drag all of the X11 dependencies. Both will work on Wayland and X11, but when no X11 headers are found the resulting binary will only work on Wayland. |
You need X11 libraries/headers to build Mesa with OpenGL support. What we really need is optional OpenGL support. |
No you don’t, since glvnd introduced the new libOpenGL ABI you can build Mesa with desktop OpenGL support without depending on libGLX or X11 libraries. #6835 would be nice to fix though, I might give it a try after that. |
With latest Mesa and libglvnd git:
EDIT: I suppose GLX isn't needed at all anymore. Will try this out. |
bc2b03d
to
f5b8121
Compare
The check for either wayland or X11 is still missing too. You should require at least one of them; else no compilation. You need to add it to cmake file since X11 is now not required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See this comment.
This makes it possible to build rpcs3 on a pure Wayland system, without the Xlib installed.
f5b8121
to
12db795
Compare
Hi, this should be all done now. :) Sorry for not reacting earlier, I’ve been pretty busy organising for the general strike in France lately. |
No rush really, its understandable you may have more important things to do. Will review as soon as possible. |
This makes it possible to build rpcs3 on a pure Wayland system, without the Xlib installed.