Support mouse wheel binding #7148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSuih
force-pushed
the
mousewheel
branch
6 times, most recently
from
a85454c
to
3652250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mousewheel as a bindable button to keyboard handler. Theoretically supports 4-directional scroll wheels, but I don't have one to test with.
Since there's no event for "wheel movement has stopped", I've added a check that releases the button on the emulated controller when 0,1 seconds has passed since last wheel scroll to the same direction. This means that the button is considered to being held down as long as you keep scrolling, but it makes button mashing more difficult.
Should support scroll gestures on touchpads as well, but I doubt anyone is interested in trying that in action.
Closes #5396