Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Add tooltips to Virtual File System buttons #7188

Merged
merged 2 commits into from Jan 4, 2020

Conversation

CookiePLMonster
Copy link
Contributor

@CookiePLMonster CookiePLMonster commented Jan 3, 2020

+/- should be self-explanatory, but in case somebody doesn't get it tooltips have been added.

Also made "+" and "-" not translatable as it was stupid.

@Megamouse
Copy link
Contributor

It's not stupid. Could be custom to use something else somewhere.

@CookiePLMonster
Copy link
Contributor Author

It's not stupid. Could be custom to use something else somewhere.

"somewhere" - true, but for this case it should not be translatable IMO.

@AniLeo AniLeo requested a review from Megamouse January 4, 2020 02:34
@AniLeo AniLeo added the GUI label Jan 4, 2020
@Megamouse
Copy link
Contributor

Well. It's easier to skip the label in the translator than to add it back in

@Megamouse Megamouse merged commit f927943 into RPCS3:master Jan 4, 2020
@CookiePLMonster CookiePLMonster deleted the vfs-dialog-tooltip branch January 4, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants