Implement lv2_fs_mount_point #7199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekotekina
force-pushed
the
fixup
branch
3 times, most recently
from
ef2babb
to
eb74e8d
Compare
|
|
||
| if (mp_name == "dev_hdd1"sv) | ||
| return &g_mp_sys_dev_hdd1; | ||
| if (mp_name.substr(0, 7) == "dev_usb"sv) |
There was a problem hiding this comment.
There is starts_with now (C++20), but it requires /std:c++latest which may not be desirable yet.
| { | ||
| return name; | ||
| } | ||
| filename = filename.substr(0, 0x420 - 1); |
There was a problem hiding this comment.
Suggested change
| filename = filename.substr(0, 0x420 - 1); | |
| const size_t len = std::min<size_t>(filename.size(), name.size() - 1); |
With that the only place with 0x420 magic will be in name variable declaration.
Nekotekina
force-pushed
the
fixup
branch
2 times, most recently
from
2649308
to
231650e
Compare
Implement some actual mount points Implement lv2_mp_flag::no_uid_gid
Implement lv2_mp_flag::read_only. Currently only /dev_bdvd is affected.
Allow single-file case (consistently with sys_fs_open)
Don't use fs::append (not capable of). Fix sys_fs_ftruncate (remove wrong workaround).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side effect, protect dev_bdvd mount from accidental unwanted changes.