vk: Workaround for NVIDIA occlusion query failure #7216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When using partial results on NVIDIA, a non-zero result is returned even when the draw is fully occluded. This, I believe, violates spec which says the partial result shall be between 0 and the final result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asking for partial results is borked on NVIDIA drivers; this is a spec violation:
However, the value written to the result is non-zero for a fully occluded object, breaking the fast result logic which assumes results are accumulating if a non-zero result is returned.
This works around the issue by not using partial results on all nvidia drivers.