Smoother batch package installation #7222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve batch package installation:
Currently - when installing multiple .pkg files - a dialog will pop up and close itself for each file with a generic message and you don't have any indication on how far the installation has proceeded. This can get annoying if you install let's say 20 patches for Gran Turismo 6.
So I unified all installations into one dialog that stays opened until all files are installed or you cancel the installation. The dialog still tracks progress for each pkg seperately, but the message was improved in order to show how many packages are left.
I also added a new parameter to the progress_dialog that patches a bug which causes the whole application to terminate when you cancel the pkg installation.
But: package installation can't be canceled immediately, so once you cancel it the current package will still be installed in the background, even though the dialog was already closed.