rsx: Optimize some imaging operations #7260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid double transfers where a transfer to a temp image is done without scaling and then a secondary transfer follows. Combines the two steps into one whenever possible which can significantly alleviate bandwidth problems at higher resolutions. Significant speedup, upto 90% in some cases (PDF, PDF2)
- Adds the same optimization/simplification steps to complex image transfer routines. Whenever possible, multi-step transfers are collapsed into a single operation.
kd-11
changed the title
|
this pr broke E.X Troopers (OpenGL), sound and inputs work but with black screen, it was working properly on the previous build v0.0.8-9386. |
|
Open a proper bug report and attach RSX capture files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of redundant imaging operations that can be collapsed together and combined into one step. Discovered this bottleneck when reviewing #6341
It seems OGL is the most affected, I was able to gain about 75% performance improvement at 1440p on PDF (Internal res becomes 5120x2880 for that title as it uses 4x supersampling). Doesn't seem to do much for vulkan which is already very fast in that test, but I suppose it couldn't hurt to avoid doing useless work.
Fixes #6341