Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small improvement #7288

Merged
merged 3 commits into from
Jan 22, 2020
Merged

small improvement #7288

merged 3 commits into from
Jan 22, 2020

Conversation

ntfshard
Copy link
Contributor

Hello

I fixed some common issues in the code. Access to moved variable is not a good idea, for example. Also several unused local variables are removed. And lost & in a function argument.

But, some expressions are really need to be clarified, they looks like some kind of issues:

  1. rpcs3/Emu/RSX/VK/VKDMA.cpp (lines 52, 213)
    VK_BUFFER_USAGE_TRANSFER_DST_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT, 0);
    This is a same constants in a both sides of | operation;

  2. rpcs3/Emu/Cell/Modules/cellSpursSpu.cpp:696
    ctxt->selectWorkloadAddr = isKernel2 ? CELL_SPURS_KERNEL2_SELECT_WORKLOAD_ADDR : CELL_SPURS_KERNEL1_SELECT_WORKLOAD_ADDR;
    Looks legit, but in rpcs3/Emu/Cell/Modules/cellSpurs.h:114,115
    CELL_SPURS_KERNEL1_SELECT_WORKLOAD_ADDR = 0x290,
    CELL_SPURS_KERNEL2_SELECT_WORKLOAD_ADDR = 0x290,
    both constants has the same value and no comments around; That's intriguing

@kd-11
Copy link
Contributor

kd-11 commented Jan 20, 2020

For VKDMA.cpp it's a typo. It should be VK_BUFFER_USAGE_TRANSFER_SRC_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT

@AniLeo AniLeo merged commit 1abdee2 into RPCS3:master Jan 22, 2020
@ntfshard ntfshard deleted the removeunusedvars branch January 22, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants