Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Debug - LLVM build to run #7348

Merged
merged 3 commits into from Jan 31, 2020
Merged

Conversation

CookiePLMonster
Copy link
Contributor

With those changes, Debug - LLVM compiles and runs. This means debug LLVM with assertions can be used! May be useful, since atm I am getting LLVM assertions very early on already.

rpcs3/rpcs3_version.cpp Outdated Show resolved Hide resolved
Allows Debug - LLVM to boot
@Nekotekina
Copy link
Member

Against merging.

@AniLeo
Copy link
Member

AniLeo commented Jan 31, 2020

Review what's wrong then and/or the correct fix

@Nekotekina
Copy link
Member

I don't know what is the problem yet. It's more likely MSVC bug.

@Nekotekina
Copy link
Member

Nvm, I reviewed and changes seems OK.

@Nekotekina Nekotekina merged commit 9f678cc into RPCS3:master Jan 31, 2020
@CookiePLMonster CookiePLMonster deleted the debug-build branch January 31, 2020 08:57
@Megamouse Megamouse added the Build and CI Anything related to the build process and continuous integration label Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build and CI Anything related to the build process and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants