Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cellVdec Fixup #7384

Merged
merged 3 commits into from Feb 5, 2020
Merged

cellVdec Fixup #7384

merged 3 commits into from Feb 5, 2020

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Feb 3, 2020 •
edited

  • Add a workaround codec specific information ptr passed to cellVdecQueryEx, add some groundwork for proper fix.
  • Few fixes in cellVdecGetPicItem including race condition fix (vdec->mem_bias modification need to be atomic).

@elad335 elad335 force-pushed the patch-5 branch 3 times, most recently from a0b29ed to aec71b6 Compare February 4, 2020 13:53
@elad335 elad335 changed the title Fix cellVdecGetPicItem [TESTERS NEEDED] Fix cellVdecGetPicItem Feb 4, 2020
@Nerboruto
Copy link

black screen fixed in GOW GOS and ninja gaiden sigma 2...

@Nerboruto Nerboruto mentioned this pull request Feb 4, 2020
Closed
@elad335 elad335 mentioned this pull request Feb 4, 2020
Closed
@13xforever
Copy link
Contributor

Fixed all video playback issues I had with multiple games, including star ocean 4, ranko tsukigime, ni no kuni, etc

@Wontell
Copy link

Wontell commented Feb 4, 2020

Just tested Ragnarok Odyssey Ace [BLUS31386] and Ragnarok Odyssey ACE [NPEB01926]
both go in-game.

@elad335
Copy link
Contributor Author

elad335 commented Feb 4, 2020

NO MERGE

@Wontell
Copy link

Wontell commented Feb 4, 2020

Tested God of War: Ghost of Sparta [NPEA00309], FMV works, game goes in-Game.
One time RPCS3 crashed, but kept running untill i pressed the OK on the crash window notification .

If any other games needed testing let me know.

@elad335
Copy link
Contributor Author

elad335 commented Feb 4, 2020

Nvm, you can merge.

@AniLeo
Copy link
Member

AniLeo commented Feb 4, 2020

Second commit needs renaming

@elad335 elad335 changed the title [TESTERS NEEDED] Fix cellVdecGetPicItem cellVdec Fixup Feb 4, 2020
@elad335 elad335 force-pushed the patch-5 branch 3 times, most recently from db14e82 to e79f2b4 Compare February 4, 2020 20:21
@elad335 elad335 requested a review from AniLeo February 5, 2020 04:21
@AniLeo AniLeo merged commit 49e11b7 into RPCS3:master Feb 5, 2020
@AniLeo
Copy link
Member

AniLeo commented Feb 5, 2020

Merged as hotfix

@elad335 elad335 deleted the patch-5 branch February 5, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AniLeo AniLeo AniLeo approved these changes

Assignees
No one assigned
Labels
Firmware: HLE Video
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@elad335 @Nerboruto @13xforever @Wontell @AniLeo @Megamouse