Make RPCS3 compile in C++2a mode #7394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Feb 4, 2020
| @@ -951,7 +951,7 @@ settings_dialog::settings_dialog(std::shared_ptr<gui_settings> guiSettings, std: | |||
|
|
|||
| // Sliders | |||
|
|
|||
| EnhanceSlider(emu_settings::DriverWakeUpDelay, ui->wakeupDelay, ui->wakeupText, tr(u8"%0 µs")); | |||
| EnhanceSlider(emu_settings::DriverWakeUpDelay, ui->wakeupDelay, ui->wakeupText, tr(reinterpret_cast<const char*>(u8"%0 µs"))); | |||
There was a problem hiding this comment.
why is the u8 even necessary
There was a problem hiding this comment.
Without u8, it's a "string in whatever encoding compiler finds necessary". Even if file is UTF-8.
There was a problem hiding this comment.
so it's because of the µ ?
There was a problem hiding this comment.
also, I think you could also use QChar() if i'm correct.
But idk
There was a problem hiding this comment.
Maybe can use some overloaded operator""(x) for it.
Nekotekina
force-pushed
the
fixup
branch
7 times, most recently
from
12f42e8
to
d5b10b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.