RSX/SPU: Accurate reservation access (non-TSX) #7483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this not enabled by default and/or not a setting at all? Is the performance penalty that heavy? |
elad335
force-pushed
the
ugh-reserve-gcm
branch
2 times, most recently
from
fa9d6c4
to
4a35f1c
Compare
|
Made it a dynamic setting, also yes it has a noticeable perf panalty with some games (most games won't map reservation memory to RSX so perf won't be affected). |
kd-11
reviewed
Feb 14, 2020
kd-11
reviewed
Feb 14, 2020
elad335
force-pushed
the
ugh-reserve-gcm
branch
2 times, most recently
from
db5dfe5
to
7ddf1aa
Compare
elad335
force-pushed
the
ugh-reserve-gcm
branch
from
7ddf1aa
to
27b37ef
Compare
kd-11
reviewed
Feb 14, 2020
| while (Emu.IsPaused()) | ||
| { | ||
| std::this_thread::sleep_for(1ms); | ||
| } | ||
|
|
||
| // Reset | ||
| start = get_system_time(); | ||
| start += get_system_time() - start0; |
kd-11
reviewed
Feb 14, 2020
kd-11
reviewed
Feb 14, 2020
elad335
force-pushed
the
ugh-reserve-gcm
branch
from
27b37ef
to
735354e
Compare
kd-11
approved these changes
Feb 14, 2020
woj1993
reviewed
Feb 14, 2020
|
Needs rebase |
elad335
force-pushed
the
ugh-reserve-gcm
branch
from
4186f25
to
2922c78
Compare
|
Rebased. |
Affects cellGcmAddressToOffset when using addresses above 0xC0000000
elad335
force-pushed
the
ugh-reserve-gcm
branch
from
2922c78
to
1e42a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect SPU reservation from the evil RSX which may damage it.
Fixes God Of War Ascension with non-tsx when enabled, this setting is located in advanced tab.