Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic.hpp: C-style casts cleanup #7485

Merged
merged 2 commits into from Feb 15, 2020
Merged

atomic.hpp: C-style casts cleanup #7485

merged 2 commits into from Feb 15, 2020

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Feb 14, 2020

Use std::bit_cast, reinterpret_cast and const_cast instead.

@elad335 elad335 force-pushed the atomic-c branch 3 times, most recently from 05c83aa to 942b0aa Compare February 14, 2020 14:25
@Nekotekina
Copy link
Member

Nekotekina commented Feb 14, 2020

Is it really worth it? I mean, not particularly against it, but it's highly special MSVC code...

@elad335 elad335 force-pushed the atomic-c branch 6 times, most recently from 75c9ed6 to 1cea170 Compare February 14, 2020 20:12
Was this close to enter programmers' hell.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants