Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellGame, sys_ss rng fixes #7547

Merged
merged 4 commits into from Feb 21, 2020
Merged

cellGame, sys_ss rng fixes #7547

merged 4 commits into from Feb 21, 2020

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Feb 21, 2020

improvements to sys_ss_random_number_generator:

  • Replace CELL_EABORT with exception.
  • Improve error codes a bit.
  • pkg_id == 1 should not return an error if root permission is present.
  • Avoid passing vm pointers to native API, use temp buffer instead.

cellGame/DiscGame improvements:

@Nekotekina
Copy link
Member

Nekotekina commented Feb 21, 2020

I don't think that converting serious system failure to some CELL_* error is a good idea.

@elad335
Copy link
Contributor Author

elad335 commented Feb 21, 2020

Removed CELL_EABORT from the syscall.

* Replace CELL_EABORT with exception.
* Improve error codes a bit.
* pkg_id == 1 should not return an error if root permission is present.
* Avoid passing vm pointers to native API, use temp buffer instead.
* Always set first dword to 0, other bytes are untouched,
* setParam is nullptr by default.
* if setParam is null and it's new data, return error code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants