Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hle: Fix cellAvconfExt wrongly registered functions #7556

Merged
merged 1 commit into from Feb 22, 2020

Conversation

AniLeo
Copy link
Member

@AniLeo AniLeo commented Feb 22, 2020

Co-authored-by: Clienthax

Torne TV App exposed an unregistered function
E {PPU[0x1000000] Thread (main_thread) [0x005d0000]} PPU: Unregistered function called (LR=0x2a3b8)

We figured out it was from libsysutil_avconf_ext

·! 0:01:52.448828 ppu_loader: ** Imported module 'cellSysutilAvconfExt' (ver=0x1, attr=0x9, 0x0, 0x0) [0x49940c]
·! 0:01:52.448829 ppu_loader: **** cellSysutilAvconfExt import: [cellVideoOutSetCopyControl] -> 0x490ecc
·! 0:01:52.448831 ppu_loader: **** cellSysutilAvconfExt import: [0x341D9459] -> 0x490eec
·! 0:01:52.448832 ppu_loader: **** cellSysutilAvconfExt import: [0x9FAA12BE] -> 0x490f0c

Upon checking, we noticed some functions were registered to the wrong modules. 0x9FAA12BE (cellVideoOutConfigure2) was already registered, but to cellSysutil instead of cellSysutilAvconfExt, for example.

Now Torne TV App correctly calls
U {PPU[0x1000000] Thread (main_thread) [0x005d0328]} cellAvconfExt TODO: cellVideoOutConfigure2()

Co-authored-by: Clienthax <clienthax@gmail.com>
@Megamouse
Copy link
Contributor

wow. I thought their location wouldn't matter.
I saw a lot more functions in weird locations 🤔

@AniLeo
Copy link
Member Author

AniLeo commented Feb 22, 2020

They have to be registered to the proper module (you could keep them on the other cpp files as long as you registered them to cellSysutilAvconfExt instead of cellSysutil), otherwise it is just as if they were unregistered

@Nekotekina Nekotekina merged commit fa3fde7 into RPCS3:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants