Fix a few more warnings and build stuff #7563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 10 is not yet required and is not very available
- Compiler warnings indicated that the call to toStdString() did not create an object that lived long enough be used. Simply use std string ahead of time.
elad335
requested changes
Feb 23, 2020
JohnHolmesII
force-pushed
the
buildops
branch
from
30c19a9
to
b77c685
Compare
|
I take it ignoring -Winit-list-lifetime has no effect? |
|
It didn't seem to work inline, as the warnings are in the master logs. I could try adding it the the top level if you want. |
Megamouse
added
the
Build and CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat noisy, may be worth squashing. There may also be better solutions to some parts.